Remove ok_with_force_push toggle from UI #11889
Merged
+0
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Author
|
@krlvi just fyi, I noticed this setting is now unused by the backend. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the obsolete "Allow force pushing" UI toggle from the GitForm component. The ok_with_force_push project property is no longer exposed in the settings form, as only force_push_protection is actively used. The PR cleanly removes the toggle UI component and its associated event handler function.
Changes:
- Removed
onForcePushClickhandler function that updatedok_with_force_push - Removed CardGroup.Item containing the "Allow force pushing" toggle UI and its description
- Simplified the GitForm to only show the "Force push protection" toggle
Remove the obsolete "Allow force pushing" toggle and its handler from the GitForm UI. The project property ok_with_force_push is no longer exposed in the form; only force_push_protection remains. This cleans up unused UI and event handling related to force-push toggling.
mtsgrd
force-pushed
the
remove-ok-with-force-push-toggle
branch
from
8c852c9 to
cfbe5a6
Compare
Contributor
Author
|
Member
|
perfect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the obsolete "Allow force pushing" toggle and its handler from the GitForm UI. The project property ok_with_force_push is no longer exposed in the form; only force_push_protection remains. This cleans up unused UI and event handling related to force-push toggling.