Skip to content

Conversation

@carolhanna01
Copy link

No description provided.

Copy link
Collaborator

@sandybrownlee sandybrownlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good - just a couple of thoughts:

For using "iteration" as the evaluation number - good question. It's not an evaluation as such, but we do probably want to track it somehow still. Maybe we still use iteration, but instead of 0 for fitness we use NaN? So the patch shows as obviously not evaluated.

For Action A; keeping the solution needs us to do bestPatch = patch either as part of implementClusterAction or just after it as bestPatch is what will be used to make the neighbour next time. We don't want to do "best = newFitness" though as we don't have a fitness.

More minor things:

Do we want to add a parameter to allow easy reversion back to the original behaviour? Something like

@Argument(alias = "pc", description = "Enable patchCat")
protected Boolean patchCat = false;

Then just an if block around "enable patchcat integration"

It's worth changing the System.out.println() calls to Logger.info()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants