Adding hashed account ID to requests to fix bad request responses #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to update the VERSION to 4.16.0 And hopefully we can get a merge |
|
Can this be merged back into Main and a new version released? |
|
The version might need updated, my own testing shows a response saying v 4.16.0 minimum now |
|
Added PR #59 to update minimum version required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For me, the integration didn't work as the API now requires the hashed account ID to be send with the other request.
This PR adds this functionality by obtaining and hashing the account ID from the login request, when the Bearer token is also obtained. I also bumped the version, because with 4.9 the API responds that it doesn't support that version any longer.