Skip to content

Conversation

@Ahajha
Copy link
Contributor

@Ahajha Ahajha commented Feb 4, 2026

There's a new version that's been out for a while that addresses the issues mentioned in #14200. There's a long chain of reasons I would like this change, but the short version is that it allows people who use both sentencepiece and gguf to take advantage of these fixes. On conda-forge, currently, it locks the version (since there is no notion of optional dependencies).

Regardless, I don't think this should be too controversial.

There's a new version that's been out for a while that addresses the issues mentioned in ggml-org#14200. There's a long chain of reasons I would like this change, but the short version is that it allows people who use both `sentencepiece` and `gguf` to take advantage of these fixes. On conda-forge, currently, it locks the version (since there is no notion of optional dependencies).

Regardless, I don't think this should be too controversial.
@Ahajha Ahajha requested a review from CISC as a code owner February 4, 2026 05:55
@github-actions github-actions bot added the python python script changes label Feb 4, 2026
Copy link
Collaborator

@CISC CISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, could you also update requirements/requirements-convert_legacy_llama.txt?

@ehoogeveen-medweb
Copy link

The range for sentencepiece in pyproject.toml was updated from
sentencepiece = ">=0.1.98,<0.2.0"
to
sentencepiece = ">=0.1.98,<=0.2.0"
in #5664

But I wonder if this was intentional or if the intent was simply to allow 0.2.0 (the latest version at the time) and the actual range should have been
sentencepiece = ">=0.1.98,<0.3.0"
to align with semantic versioning (where versions <1.0 use the convention 0.major.minor, so 0.3.0 would be a major release with breaking changes while 0.2.x are minor releases).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python python script changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants