ggml-webgpu: JIT compile binary operators and handle binding overlaps #19310
+346
−334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add binary.wgsl: unified shader with conditionals for all 4 ops * Add gen_binary_shaders.cpp: build tool for using pre_wgsl preprocessor * Remove bin_op.tmpl.wgsl and binary.wgsl (Python template) * Update CMake to generate binary operator shaders at build time
* port binary operators from AOT to pre-wgsl JIT compilation * add src1=dst overlap handling for binary ops * use compile-time workgroup size defines instead of runtime overrides
* add support for inplace & overlap case in binding setup * restructure conditional logic to handle all overlap cases * ensure all buffer bindings are correctly assigned for edge cases
github-actions
bot
added
the
ggml
reeselevine
reviewed
Feb 4, 2026
| #if defined(INPLACE) && defined(OVERLAP) | ||
|
|
||
| fn update(dst_i: u32, src0_i: u32, src1_i: u32) { | ||
| #ifdef OP_ADD |
Collaborator
There was a problem hiding this comment.
I think there's a way to avoid the duplication of all these ifdefs for different versions of inplace/overlap. Not sure if what I'm thinking is best macro practice though... something like one statement of
DST[dst_i] = SRC_A[src0_i] OP SRC_B[src1_i]
where DST, SRC_A, SRC_B, and OP are all defined based on the type.
Also, are all the combinations of src0/src1/dst necessary right now?
| int type; | ||
| int op; | ||
| bool inplace; | ||
| bool overlap; |
Collaborator
There was a problem hiding this comment.
can this name be more descriptive, since we have multiple types of overlap?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporates the following changes for the webGPU backend: