spec : fix the check-rate logic of ngram-simple #19261
Merged
+18
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
force-pushed
the
gg/spec-simple-freq-check
branch
from
dee323f to
b3fa165
Compare
|
Thank you very much, it works perfectly now with this fix. |
srogmann
approved these changes
Feb 3, 2026
Collaborator
srogmann
left a comment
srogmann
left a comment
There was a problem hiding this comment.
Should we remove the config parameter --spec-ngram-check-rate completely? This parameter was introduced when we didn't have the hash maps in ngram-map-* and ngram-mod. The ngram-simple implementation would get a bit simpler (less risk of bugs like in #19231 ).
Member
Author
Yes, let's remove it. Feel free to PR the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #19231
For the
spec-simplemethod, we don't need to keep track of the last length to rate-limit the generations. We can simply use an incremental counter. This makes the speculator work with "Regenerate" of last message or branching the conversation from previous messages.Also, removed
struct common_ngram_simple_state- seemed a bit redundant.