-
Notifications
You must be signed in to change notification settings - Fork 14.8k
chat : add parsing for solar-open-100b #18540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@HelloKS, thanks for that info. I should have done more thorough testing with |
|
Yes, It now works without reasoning (even with tooling!) |
|
Have you tried Any additional |
Minimal and low does the same behavior. I think it's ok because they didn't document this "reasoning off" feature. Maybe it was planned leftover, who will know lol |
|
any progress? |
It works perfectly (I'm using it locally), but just PR progress is stalled. Maybe related to #18675 ? |
pwilkin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry. Yeah, let's merge it.
|
@0cc4m @jeffbolznv Just FYI getting this test failure on CI: FLASH_ATTN_EXT(hsk=128,hsv=128,nh=4,nr23=[12,1],kv=512,nb=35,mask=1,sinks=0,max_bias=8.000000,logit_softcap=10.000000,prec=def,type_KV=f32,permute=[0,1,2,3]) |
|
Yeah, I'm aware of it, it only showed up after the merge of #19075, but not on the branch itself. I'll look into it. |
|
@pwilkin thank you! |
* chat : add parsing for solar-open-100b * add comments to rules * cont : make assistant start optional * cont : remove assistant start prefix altogether --------- Co-authored-by: Piotr Wilkin (ilintar) <piotr.wilkin@syndatis.com>




Chat parser for Solar-Open-100B.
Features
reasoning_contentfield for interleaved thinkingresponse_formatparsingtool_choice = requiredand reasoningThe following variables can be modified via chat template kwargs:
default_system_prompt: bool = true- Include default system promptreasoning_effort: "minimal" | "low" | "medium" | "high" = "high"- Set reasoning effort. When set toloworminimal, reasoning is disabled.think_render_option: "all" | "lastthink" = "lastthink"- Determines when to render reasoning traces when fed back for interleaved rendering. The default (lastthink) only includes reasoning after the last user message. Thealloption includes reasoning for all assistant messages.