feat: support pull requests with more than 300 changed files #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use paginated pulls.listFiles API instead of pulls.get with diff format, which has a 300 file limit. Add parsePatch function to handle individual file patches from the listFiles response.
deviantintegral
commented
Jan 19, 2026
src/utils/diff.ts
Outdated
Comment on lines
11
to
14
| export function parsePatch(patch: string | undefined): number[] { | ||
| if (!patch) { | ||
| return [] | ||
| } |
Contributor
Author
There was a problem hiding this comment.
It's not clear to me this is a possible case. I think this may be better without undefined.
deviantintegral
commented
Jan 19, 2026
| @@ -1,5 +1,5 @@ | |||
| import * as core from '@actions/core' | |||
| import * as diff from './diff' | |||
| import {parsePatch} from './diff' | |||
Contributor
Author
There was a problem hiding this comment.
I should check, because there may be a function we could remove or this should go back to *.
Contributor
Author
There was a problem hiding this comment.
parseGitDiff is no longer called except in tests. Should we keep it or remove it?
Contributor
Author
|
🥳 
|
Move undefined check to the caller in getPullRequestDiff where file.patch may be undefined from the GitHub API response.
Contributor
Author
|
@ggilder This is ready for review. Thanks for your work on this action, I've used it in several projects over the past few weeks and it's worked nicely! |
ggilder
approved these changes
Jan 19, 2026
Owner
ggilder
left a comment
ggilder
left a comment
There was a problem hiding this comment.
Looks great, thank you for the contribution!
Owner
|
Just released 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this over at deviantintegral/pantheon-metrics-prometheus#46. That project vendors dependencies (which is common in golang at least), and making updates to them triggered an error for annotations.
https://github.com/deviantintegral/pantheon-metrics-prometheus/actions/runs/21081006077/job/60634487862
I'm in the process of reviewing and testing this now, I'll mark it as ready when I'm done!