More robustly handle sample names in indel VCF headers#32
Draft
julianhess wants to merge 4 commits intomasterfrom
Draft
More robustly handle sample names in indel VCF headers#32julianhess wants to merge 4 commits intomasterfrom
julianhess wants to merge 4 commits intomasterfrom
Conversation
Author
|
I've confirmed this works with Strelka VCFs, both malformed and header fixed. Need to test on M2 and Sanger before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VCF spec demands that the samples' column names match entries in the header (e.g. if
##normal_sample=MY_NORMALis present in the header, then the column for the normal should be namedMY_NORMAL.)Previously, deTiN would break on otherwise valid indel VCFs. This fixes that. As a bonus, the deTiN output should be easier to merge with the input VCF, since the VCF column names are preserved.