Skip to content

fix: add cleanup handlers for EventSource connection in cli tail #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shubhdeep12 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add cleanup handlers for EventSource connection in cli tail #1258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions packages/spotlight/src/server/cli/tail.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,22 @@ export async function handler(
try {
const client = await connectUpstream(port);
client.addEventListener(SENTRY_CONTENT_TYPE, event => onEnvelope!(JSON.parse(event.data)));

// Set up cleanup handlers to close the EventSource connection
const cleanup = (): void => {
try {
if (client.readyState !== 2) {
client.close();
}
} catch (_err) {
// Ignore errors because maybe client is already closed
}
};

process.on("SIGINT", cleanup);
process.on("SIGTERM", cleanup);
process.on("beforeExit", cleanup);

// Early return - don't start our own server if we can connect to an upstream one
return undefined;
} catch (err) {
Expand Down
Loading