Draft
Conversation
Co-authored-by: burak.kaya <burak.kaya@sentry.io>
Co-authored-by: burak.kaya <burak.kaya@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
BYK
commented
Nov 20, 2025
| -p, --port <port> Port to listen on (default: 8969, or 0 for random) | ||
| -d, --debug Enable debug logging | ||
| -f, --format <format> Output format for tail command (default: human) | ||
| -f, --format <format> Output format for tail/list command (default: human) |
Member
Author
There was a problem hiding this comment.
Suggested change
| -f, --format <format> Output format for tail/list command (default: human) | |
| -f, --format <format> Output format for commands like run, tail, and list command (default: human) |
Comment on lines
44
to
47
| return Object.entries(fields) | ||
| .map(([key, value]) => `${key}=${value}`) | ||
| .join(" "); | ||
| } |
Member
Author
There was a problem hiding this comment.
Use the existing logfmt library we have for this.
Comment on lines
87
to
111
| switch (format) { | ||
| case "human": | ||
| for (const instance of instances) { | ||
| console.log(formatHuman(instance)); | ||
| } | ||
| break; | ||
|
|
||
| case "json": | ||
| console.log(formatJson(instances)); | ||
| break; | ||
|
|
||
| case "logfmt": | ||
| for (const instance of instances) { | ||
| console.log(formatLogfmt(instance)); | ||
| } | ||
| break; | ||
|
|
||
| case "md": | ||
| console.log(formatMarkdown(instances)); | ||
| break; | ||
|
|
||
| default: | ||
| logger.error(`Unsupported format: ${format}`); | ||
| process.exit(1); | ||
| } |
Member
Author
There was a problem hiding this comment.
Instead of this switch/case block research the code for formatters and try to use existing formatters by extending them. If that's not possible, at least use the Map() architecture rather than if or switch blocks.
| @@ -0,0 +1,268 @@ | |||
| # Spotlight Control Center - Implementation Summary | |||
Member
Author
There was a problem hiding this comment.
Create new docs using the contents of this file under packages/website/src/docs and then delete this file.
TESTING_COMPLETE.md
Outdated
| @@ -0,0 +1,248 @@ | |||
| # Spotlight Control Center - Testing Complete ✅ | |||
Co-authored-by: burak.kaya <burak.kaya@sentry.io>
BYK
commented
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1136.
Spotlight Control Center
This PR introduces the Spotlight Control Center, enabling users to manage all
spotlight runinstances from a centralized UI or via a newspotlight listCLI command.Key Features:
spotlight runinstances, including health checks (HTTP, PID, start time) and automatic cleanup of stale entries.spotlight listCLI Command: A new command to list running instances with support for human, JSON, logfmt, and Markdown output formats.pidusagefor robust process management across Linux, macOS, and Windows.Why this change?
This feature addresses the need for better visibility and control over multiple running Spotlight instances, improving the developer experience by simplifying instance management and debugging.
Testing Notes:
spotlight listand instance registration) has been thoroughly tested and verified.