fix(admin): add quotes around cluster name in ON CLUSTER clause #7709
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ON CLUSTER clause in ClickHouse requires the cluster name to be quoted. Updated the table copy logic to wrap cluster_name in single quotes and updated corresponding tests to match the expected output. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
phacops
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ON CLUSTER clause in ClickHouse needs quotes for cluster names with hyphens. This PR updates the table copy logic to wrap
cluster_namein single quotes when constructing the CREATE TABLE statements.Test plan
tests/admin/clickhouse/test_copy_tables.py🤖 Generated with Claude Code