Skip to content

feat(cross-item): prepare settings for production #7706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
volokluev wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −3
Open

feat(cross-item): prepare settings for production #7706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7eba0e
prepare settings for production
volokluev Feb 2, 2026
fc23b31
Merge branch 'master' into volo/cross_item_prod_settings
volokluev Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion snuba/web/rpc/v1/resolvers/R_eap_items/resolver_time_series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ def resolve(
# When trace_filters are present and the feature is enabled, don't use sampling on the outer query
# The inner query (getting trace IDs) will use sampling
cross_item_queries_no_sample_outer = state.get_int_config(
"cross_item_queries_no_sample_outer", 0
"cross_item_queries_no_sample_outer", 1
)
if not (in_msg.trace_filters and cross_item_queries_no_sample_outer):
query_settings.set_sampling_tier(routing_decision.tier)
Expand Down
2 changes: 1 addition & 1 deletion snuba/web/rpc/v1/resolvers/R_eap_items/resolver_trace_item_table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,7 +581,7 @@ def resolve(
# When trace_filters are present and the feature is enabled, don't use sampling on the outer query
# The inner query (getting trace IDs) will use sampling
cross_item_queries_no_sample_outer = state.get_int_config(
"cross_item_queries_no_sample_outer", 0
"cross_item_queries_no_sample_outer", 1
)
if not (in_msg.trace_filters and cross_item_queries_no_sample_outer):
query_settings.set_sampling_tier(routing_decision.tier)
Expand Down
4 changes: 3 additions & 1 deletion snuba/web/rpc/v1/resolvers/common/cross_item_queries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@
treeify_or_and_conditions,
)

_TRACE_LIMIT = 10000
# 50 million trace ids * 16 bytes per id = a limit of 1gigabyte memory usage per cross item query
# most queries do not hit this number this is just an upper bound
_TRACE_LIMIT = 50_000_000


def convert_trace_filters_to_trace_item_filter_with_type(
Expand Down
Loading