ref(eap-items): Stop double writing booleans into float columns #7689
+0
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boolean attributes were being written to both `attributes_bool` and `attributes_float_*` columns. This removes the redundant float write, so booleans are now only stored in `attributes_bool`. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Change overflow from hidden to auto to enable scrolling. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Remove the `some_bool: 1.0` from `attributes_float_6` in the test snapshot since booleans are no longer double-written to float columns. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This reverts commit 5a6dedc.
onewland
approved these changes
Jan 30, 2026
phacops
added a commit
to getsentry/sentry
that referenced
this pull request
Jan 30, 2026
## Summary - Remove incorrect `message.parameter.0` expectation from the trace item attributes logs test - This is in relation to stop double writing bools as floats in Snuba getsentry/snuba#7689 ## Test plan - CI should pass with updated test expectations
priscilawebdev
pushed a commit
to getsentry/sentry
that referenced
this pull request
Feb 2, 2026
## Summary - Remove incorrect `message.parameter.0` expectation from the trace item attributes logs test - This is in relation to stop double writing bools as floats in Snuba getsentry/snuba#7689 ## Test plan - CI should pass with updated test expectations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
attributes_bool, no longer duplicated inattributes_float_*Test plan
🤖 Generated with Claude Code