Skip to content

feat(ci): Toggle snuba through devservices #7580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hubertdeng123 wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

feat(ci): Toggle snuba through devservices #7580

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af644bf
trying to toggle snuba
hubertdeng123 Dec 5, 2025
f87e11a
attempt to set coderoot manually
hubertdeng123 Dec 5, 2025
9166a6e
attempt again
hubertdeng123 Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,26 +304,30 @@ jobs:
with:
repository: getsentry/sentry
path: sentry
ref: hubertdeng123/add-toggle-setup-sentry-gha

- name: Setup steps
id: setup
run: |
# We cannot execute actions that are not placed under .github of the main repo
mkdir -p .github/actions
cp -r sentry/.github/actions/* .github/actions
# Move sentry to be a sibling of snuba so devenv can find both
mv sentry ../sentry
# Create devenv config
mkdir -p ~/.config/sentry-devenv
echo -e "[devenv]\ncoderoot = $GITHUB_WORKSPACE/.." > ~/.config/sentry-devenv/config.ini

- name: Setup Sentry
id: setup-sentry
uses: ./.github/actions/setup-sentry
with:
workdir: sentry
workdir: ../sentry
mode: minimal
toggle: snuba

- name: Start snuba
run: |
# TODO(hubertdeng123): New devservices doesn't support running sentry without snuba yet, remove this when it does
docker stop snuba-snuba-1
docker rm snuba-snuba-1
docker run -d --rm \
-p 127.0.0.1:1218:1218 \
-e PYTHONUNBUFFERED=1 \
Expand All @@ -343,15 +347,15 @@ jobs:

- name: Run snuba tests
if: needs.files-changed.outputs.api_changes == 'false'
working-directory: sentry
working-directory: ../sentry
run: |
pytest -k 'not __In' tests \
-m snuba_ci \
-vv --cov . --cov-report="xml:.artifacts/snuba.coverage.xml"

- name: Run full tests
if: needs.files-changed.outputs.api_changes == 'true'
working-directory: sentry
working-directory: ../sentry
run: |
pytest -k 'not __In' \
tests/snuba \
Expand All @@ -373,7 +377,7 @@ jobs:

- name: Run CI module tests
if: needs.files-changed.outputs.api_changes == 'true'
working-directory: sentry
working-directory: ../sentry
run: pytest -k 'not __In' tests -vv -m snuba_ci

clickhouse-versions:
Expand Down
Loading