Skip to content

test(issue-ownership): codeowners matching suffixes #104398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cvxluo wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

test(issue-ownership): codeowners matching suffixes #104398

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 59 additions & 0 deletions tests/sentry/issues/ownership/test_grammar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1185,3 +1185,62 @@ def test_codeowners_leading_slash_matching(
pattern: str, path_details: Sequence[Mapping[str, str]], expected: bool
) -> None:
_assert_matcher(Matcher("codeowners", pattern), path_details, expected)


@pytest.mark.parametrize(
"pattern, path_details, expected",
[
# These should NOT match - they contain "example.py" as a suffix but
# the filename is not exactly "example.py"
(
"/**/example.py",
[{"filename": "/src/bad_example.py"}, {"abs_path": "/src/bad_example.py"}],
False,
),
(
"/**/example.py",
[{"filename": "/src/foo/bad_example.py"}, {"abs_path": "/src/foo/bad_example.py"}],
False,
),
(
"/**/example.py",
[{"filename": "/src/my_example.py"}, {"abs_path": "/src/my_example.py"}],
False,
),
(
"/**/example.py",
[
{"filename": "/src/voice/calls/inbound/bad_example.py"},
{"abs_path": "/src/voice/calls/inbound/bad_example.py"},
],
False,
),
(
"/**/example.py",
[{"filename": "/src/good_example.py"}, {"abs_path": "/src/good_example.py"}],
False,
),
(
"/**/example.py",
[{"filename": "/src/test_example.py"}, {"abs_path": "/src/test_example.py"}],
False,
),
(
"**/example.py",
[{"filename": "/src/example.py"}, {"abs_path": "/src/example.py"}],
True,
),
(
"**/example.py",
[{"filename": "/src/bad_example.py"}, {"abs_path": "/src/bad_example.py"}],
False,
),
],
)
def test_codeowners_double_star_matching(
pattern: str, path_details: Sequence[Mapping[str, str]], expected: bool
) -> None:
"""
"/**/example.py" pattern should only match files named exactly "example.py" at any directory depth.
"""
_assert_matcher(Matcher("codeowners", pattern), path_details, expected)
Loading