-
-
Notifications
You must be signed in to change notification settings - Fork 355
chore(deps): Bump E2E tests to 0.83.1 #5492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9bf5446+dirty | 442.47 ms | 452.14 ms | 9.67 ms |
| a941c72+dirty | 489.85 ms | 549.17 ms | 59.32 ms |
| 93137d1+dirty | 400.15 ms | 424.74 ms | 24.59 ms |
| 1853710 | 555.47 ms | 556.59 ms | 1.12 ms |
| b80b14f+dirty | 505.06 ms | 534.32 ms | 29.26 ms |
| 69602ce | 417.47 ms | 443.52 ms | 26.05 ms |
| 23080e5 | 384.85 ms | 382.57 ms | -2.28 ms |
| 3312430+dirty | 362.54 ms | 368.76 ms | 6.22 ms |
| 493c1a1+dirty | 439.32 ms | 424.65 ms | -14.67 ms |
| 8a4ce6f | 422.88 ms | 408.33 ms | -14.55 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9bf5446+dirty | 43.75 MiB | 48.04 MiB | 4.29 MiB |
| a941c72+dirty | 43.75 MiB | 48.05 MiB | 4.29 MiB |
| 93137d1+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| 1853710 | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| b80b14f+dirty | 43.75 MiB | 48.04 MiB | 4.29 MiB |
| 69602ce | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| 23080e5 | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| 3312430+dirty | 17.75 MiB | 19.75 MiB | 2.00 MiB |
| 493c1a1+dirty | 43.75 MiB | 48.02 MiB | 4.27 MiB |
| 8a4ce6f | 17.75 MiB | 19.68 MiB | 1.94 MiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9bf5446+dirty | 423.53 ms | 461.73 ms | 38.20 ms |
| 20daa0a+dirty | 352.33 ms | 424.30 ms | 71.98 ms |
| a941c72+dirty | 381.92 ms | 436.63 ms | 54.71 ms |
| e76d0d3+dirty | 358.22 ms | 378.65 ms | 20.43 ms |
| 9f211e3+dirty | 371.00 ms | 432.51 ms | 61.51 ms |
| b80b14f+dirty | 320.33 ms | 376.06 ms | 55.73 ms |
| 1226664+dirty | 377.65 ms | 453.94 ms | 76.29 ms |
| c7f264b+dirty | 356.98 ms | 407.46 ms | 50.48 ms |
| c94a927+dirty | 411.32 ms | 443.18 ms | 31.86 ms |
| 170d5ea+dirty | 348.79 ms | 406.94 ms | 58.15 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9bf5446+dirty | 43.94 MiB | 48.87 MiB | 4.93 MiB |
| 20daa0a+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| a941c72+dirty | 43.94 MiB | 48.87 MiB | 4.93 MiB |
| e76d0d3+dirty | 7.15 MiB | 8.44 MiB | 1.28 MiB |
| 9f211e3+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| b80b14f+dirty | 43.94 MiB | 48.87 MiB | 4.93 MiB |
| 1226664+dirty | 7.15 MiB | 8.46 MiB | 1.30 MiB |
| c7f264b+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| c94a927+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
| 170d5ea+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0d6e618+dirty | 1226.16 ms | 1221.66 ms | -4.50 ms |
| 93137d1+dirty | 1230.73 ms | 1230.98 ms | 0.25 ms |
| a941c72+dirty | 1226.39 ms | 1223.60 ms | -2.78 ms |
| 294387d+dirty | 1197.73 ms | 1208.35 ms | 10.61 ms |
| 7be1f99+dirty | 1226.69 ms | 1217.76 ms | -8.93 ms |
| 21c9e75+dirty | 1237.78 ms | 1247.66 ms | 9.88 ms |
| d081295+dirty | 1214.40 ms | 1211.27 ms | -3.13 ms |
| 5c16cdc+dirty | 1209.32 ms | 1210.67 ms | 1.35 ms |
| 0b64753+dirty | 1232.49 ms | 1226.96 ms | -5.53 ms |
| 161947d+dirty | 1203.43 ms | 1217.00 ms | 13.57 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0d6e618+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| 93137d1+dirty | 2.63 MiB | 3.99 MiB | 1.35 MiB |
| a941c72+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| 294387d+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| 7be1f99+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 21c9e75+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| d081295+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| 5c16cdc+dirty | 2.63 MiB | 3.96 MiB | 1.33 MiB |
| 0b64753+dirty | 2.63 MiB | 3.98 MiB | 1.35 MiB |
| 161947d+dirty | 2.63 MiB | 3.99 MiB | 1.36 MiB |
antonis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocked on the addition of 0.83.1 in https://github.com/react-native-community/rn-diff-purge
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0d6e618+dirty | 1191.59 ms | 1190.35 ms | -1.24 ms |
| 93137d1+dirty | 1232.69 ms | 1245.18 ms | 12.49 ms |
| a941c72+dirty | 1187.82 ms | 1192.13 ms | 4.30 ms |
| 294387d+dirty | 1199.23 ms | 1204.16 ms | 4.93 ms |
| 7be1f99+dirty | 1222.43 ms | 1217.15 ms | -5.28 ms |
| 21c9e75+dirty | 1206.20 ms | 1223.54 ms | 17.35 ms |
| d081295+dirty | 1205.24 ms | 1207.52 ms | 2.28 ms |
| 5c16cdc+dirty | 1235.67 ms | 1241.18 ms | 5.51 ms |
| 0b64753+dirty | 1225.77 ms | 1232.98 ms | 7.21 ms |
| 161947d+dirty | 1203.45 ms | 1217.83 ms | 14.38 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0d6e618+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| 93137d1+dirty | 3.19 MiB | 4.55 MiB | 1.37 MiB |
| a941c72+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| 294387d+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| 7be1f99+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 21c9e75+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| d081295+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| 5c16cdc+dirty | 3.19 MiB | 4.53 MiB | 1.34 MiB |
| 0b64753+dirty | 3.19 MiB | 4.55 MiB | 1.36 MiB |
| 161947d+dirty | 3.19 MiB | 4.56 MiB | 1.37 MiB |
|
We don't have any guidelines regarding that but in general I don't think that bumping RN version for e2e tests is that needed for every minor version, it's just too much hassle with not so many benifits. Maybe we should do it only for major versions? |
📢 Type of change
📜 Description
Bump E2E tests to 0.83.1
💡 Motivation and Context
https://github.com/facebook/react-native/releases/tag/v0.83.1
💚 How did you test it?
CI, Manual
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog