Skip to content

fix(pure-eval): Guard against module shadowing #5252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexander-alderman-webb wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(pure-eval): Guard against module shadowing #5252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sentry_sdk/integrations/pure_eval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@
from sentry_sdk._types import Event, Hint

try:
import executing
from executing import Source
except ImportError:
raise DidNotEnable("executing is not installed")

try:
import pure_eval
from pure_eval import Evaluator
except ImportError:
raise DidNotEnable("pure_eval is not installed")

Expand Down Expand Up @@ -81,7 +81,7 @@ def add_executing_info(


def pure_eval_frame(frame: "FrameType") -> "Dict[str, Any]":
source = executing.Source.for_frame(frame)
source = Source.for_frame(frame)
if not source.tree:
return {}

Expand All @@ -98,7 +98,7 @@ def pure_eval_frame(frame: "FrameType") -> "Dict[str, Any]":
if isinstance(scope, (ast.FunctionDef, ast.ClassDef, ast.Module)):
break

evaluator = pure_eval.Evaluator.from_frame(frame)
evaluator = Evaluator.from_frame(frame)
expressions = evaluator.interesting_expressions_grouped(scope)

def closeness(expression: "Tuple[List[Any], Any]") -> "Tuple[int, int]":
Expand Down
1 change: 0 additions & 1 deletion tests/test_shadowed_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ def pytest_generate_tests(metafunc):
"grpc",
"litellm",
"opentelemetry",
"pure_eval",
"ray",
"trytond",
"typer",
Expand Down
Loading