Skip to content

Conversation

@github-actions
Copy link
Contributor

Bumps scripts/update-gradle.sh from v8.14.3 to v9.2.1.

Auto-generated by a dependency updater.

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Nov 17, 2025
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-gradle.sh/v9.2.1 branch 3 times, most recently from b1e59b5 to bc287ba Compare November 19, 2025 13:29
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.3-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-9.2.1-bin.zip
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Gradle wrapper JAR not updated with version bump

The distributionUrl was updated to Gradle 9.2.1, but the gradle-wrapper.jar binary file was not updated. When the wrapper distribution URL is changed, the wrapper JAR should also be regenerated or updated to ensure compatibility. This mismatch could cause build failures or unexpected behavior when developers or CI/CD systems use the wrapper.

Fix in Cursor Fix in Web

@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-gradle.sh/v9.2.1 branch 14 times, most recently from 2586221 to b69348d Compare November 26, 2025 16:25
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-gradle.sh/v9.2.1 branch 6 times, most recently from daabbfd to e69607e Compare December 4, 2025 11:44
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-gradle.sh/v9.2.1 branch 2 times, most recently from ff7ab5b to 93c2943 Compare December 9, 2025 14:27
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-gradle.sh/v9.2.1 branch 2 times, most recently from 7456ab8 to 3fc443e Compare December 15, 2025 10:29
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.3-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-9.2.1-bin.zip

This comment was marked as outdated.

@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-gradle.sh/v9.2.1 branch 5 times, most recently from 11471e2 to bf708d3 Compare December 16, 2025 11:12
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.3-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-9.2.1-bin.zip

This comment was marked as outdated.

@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-gradle.sh/v9.2.1 branch 2 times, most recently from 5c1c3d6 to bdded88 Compare December 17, 2025 10:57
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.3-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-9.2.1-bin.zip

This comment was marked as outdated.

@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-gradle.sh/v9.2.1 branch 6 times, most recently from 683ce56 to e046d91 Compare December 22, 2025 11:47
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-gradle.sh/v9.2.1 branch from e046d91 to f3c4d6c Compare December 22, 2025 12:08
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.3-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-9.2.1-bin.zip
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Custom Test tasks will fail or be skipped after the Gradle 9.2.1 upgrade because they lack the now-required explicit testClassesDirs and classpath configurations.
Severity: CRITICAL | Confidence: High

🔍 Detailed Analysis

The upgrade to Gradle 9.2.1 introduces a breaking change from Gradle 9.0 that affects custom Test tasks. Previously, these tasks implicitly used the default test source set's classpath. Now, they require explicit configuration. The codebase contains numerous custom Test tasks, such as systemTest in over 18 sample projects, which lack the necessary testClassesDirs and classpath properties. Consequently, after this upgrade, these test tasks will fail to find any test classes, leading to either build failures or, more critically, silently skipping the entire system test suite.

💡 Suggested Fix

For each custom Test task registration, such as tasks.register<Test>("systemTest"), explicitly configure the test classes and classpath. Add the following lines inside the task's configuration block:
testClassesDirs = sourceSets["test"].output.classesDirs
classpath = sourceSets["test"].runtimeClasspath

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: gradle/wrapper/gradle-wrapper.properties#L3

Potential issue: The upgrade to Gradle 9.2.1 introduces a breaking change from Gradle
9.0 that affects custom `Test` tasks. Previously, these tasks implicitly used the
default `test` source set's classpath. Now, they require explicit configuration. The
codebase contains numerous custom `Test` tasks, such as `systemTest` in over 18 sample
projects, which lack the necessary `testClassesDirs` and `classpath` properties.
Consequently, after this upgrade, these test tasks will fail to find any test classes,
leading to either build failures or, more critically, silently skipping the entire
system test suite.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 7822598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants