docs(metrics): remove old metrics platform-includes #16058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove orphaned platform-includes files that are no longer referenced in the metrics documentation. These files appear to be remnants from a previous metrics documentation refactoring. Files removed: - configure/* (9 files) - No longer referenced by any metrics pages - counter-snippet/javascript.mdx - Unused snippet file - distribution-snippet/javascript.mdx - Unused snippet file - gauge-snippet/javascript.mdx - Unused snippet file - set-snippet/javascript.mdx - Unused snippet file - setup/javascript.mdx - Unused setup file - metrics-units/python.mdx - No references found in codebase - version-support-note/* (3 files) - No longer included in metrics pages Verified by searching for PlatformContent includePath references and direct grep searches across the documentation. The remaining files in platform-includes/metrics/ (usage, options, requirements, default-attributes) are still actively used by Python, PHP, JavaScript, Ruby, and React Native metrics documentation. Co-Authored-By: Claude <noreply@anthropic.com>
…tsentry/sentry-docs into docs/remove-old-metrics-files
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Flash0ver
changed the title
Flash0ver
changed the title
Flash0ver
requested review from
a team,
mydea and
nicohrubec
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
During getsentry/sentry-dotnet#4834 and #16054, I noticed that the Metrics dev docs still had some leftovers from the old Metrics implementation. These confused me a bit - I joined after they've been removed already.
I hope that removing them makes it easier to generate/write the metrics docs for upcoming SDKs.
Additionally, I hope that we weren't overzealous removing these platform-includes.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: