feat(mobile-ui): Collect frame delay metric #3472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narsaynorath
commented
Apr 23, 2024
...n/snapshots/relay_server__metrics_extraction__event__tests__extract_span_metrics_mobile.snap
Outdated
Show resolved
Hide resolved
narsaynorath
force-pushed
the
nar/feat/mobile-ui-collect-frame-delay-metric
branch
from
ecb51fd to
2de286c
Compare
narsaynorath
force-pushed
the
nar/feat/mobile-ui-collect-frame-delay-metric
branch
from
2de286c to
554670d
Compare
Contributor
iker-barriocanal
left a comment
iker-barriocanal
left a comment
There was a problem hiding this comment.
Similar to #3473 -- is this doable through measurements?
markushi
reviewed
Apr 23, 2024
Member
Author
|
Drafting until #3473 is settled, this PR will require changes similarly to that one. |
jjbayer
reviewed
Apr 25, 2024
Member
jjbayer
left a comment
jjbayer
left a comment
There was a problem hiding this comment.
Should this be a gauge as well? Rest looks good to me!
jjbayer
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new metric for collecting the
frames.delayproperty from a span'sdataobject in the Starfish Mobile UI module.I've added the tags that I think are necessary to query and filter for this metric, and they are common filters for other metrics in this config. Also noted is that the data is in the
dataobject, similar to #3473 and thus I modified measurement extraction to copy this value over to span measurements.