Skip to content

ref(s4s2): Switch s4s and s4s2 places in pipedream #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmajere merged 3 commits into from
Jan 5, 2026
Merged

ref(s4s2): Switch s4s and s4s2 places in pipedream #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9138a17
ref(s4s2): Make s4s2 region prod in pipelines
dmajere Dec 17, 2025
c0d132f
+fix tests
dmajere Dec 17, 2025
732d72a
-s4s to test regions
dmajere Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libs/getsentry.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
{
// These regions are user facing deployments
prod_regions: [
's4s',
's4s2',
'de',
'us',
// 'control' is excluded by default and must be explicitly included
Expand All @@ -19,7 +19,7 @@
],
// Test regions will deploy in parallel to the regions above
test_regions: [
's4s2',
's4s',
],
is_st(region):: (region == 's4s' || std.startsWith(region, 'customer-')),
}
264 changes: 217 additions & 47 deletions test/pipedream.js
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions test/testdata/goldens/getsentry/regions.jsonnet_output-files.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"all_regions": [
"s4s",
"s4s2",
"de",
"us",
"control",
Expand All @@ -9,6 +9,6 @@
"customer-2",
"customer-4",
"customer-7",
"s4s2"
"s4s"
]
}
8 changes: 4 additions & 4 deletions test/testdata/goldens/pipedream/autodeploy-parallel.jsonnet_output-files.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@
"format_version": 10,
"pipelines": {
"deploy-example-s4s": {
"display_order": 2,
"display_order": 9,
"group": "example",
"materials": {
"example_repo": {
Expand Down Expand Up @@ -231,7 +231,7 @@
"format_version": 10,
"pipelines": {
"deploy-example-s4s2": {
"display_order": 9,
"display_order": 2,
"group": "example",
"materials": {
"example_repo": {
Expand Down Expand Up @@ -309,9 +309,9 @@
"rollback-example": {
"display_order": 1,
"environment_variables": {
"ALL_PIPELINE_FLAGS": "--pipeline=deploy-example-s4s --pipeline=deploy-example-de --pipeline=deploy-example-us --pipeline=deploy-example-customer-1 --pipeline=deploy-example-customer-2 --pipeline=deploy-example-customer-4 --pipeline=deploy-example-customer-7",
"ALL_PIPELINE_FLAGS": "--pipeline=deploy-example-s4s2 --pipeline=deploy-example-de --pipeline=deploy-example-us --pipeline=deploy-example-customer-1 --pipeline=deploy-example-customer-2 --pipeline=deploy-example-customer-4 --pipeline=deploy-example-customer-7",
"GOCD_ACCESS_TOKEN": "{{SECRET:[devinfra][gocd_access_token]}}",
"REGION_PIPELINE_FLAGS": "--pipeline=deploy-example-s4s --pipeline=deploy-example-de --pipeline=deploy-example-us --pipeline=deploy-example-customer-1 --pipeline=deploy-example-customer-2 --pipeline=deploy-example-customer-4 --pipeline=deploy-example-customer-7",
"REGION_PIPELINE_FLAGS": "--pipeline=deploy-example-s4s2 --pipeline=deploy-example-de --pipeline=deploy-example-us --pipeline=deploy-example-customer-1 --pipeline=deploy-example-customer-2 --pipeline=deploy-example-customer-4 --pipeline=deploy-example-customer-7",
"ROLLBACK_MATERIAL_NAME": "example_repo",
"ROLLBACK_STAGE": "example_stage",
"TRIGGERED_BY": ""
Expand Down
8 changes: 4 additions & 4 deletions test/testdata/goldens/pipedream/autodeploy-parallel.jsonnet_single-file.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@
]
},
"deploy-example-s4s": {
"display_order": 2,
"display_order": 9,
"group": "example",
"materials": {
"example_repo": {
Expand Down Expand Up @@ -200,7 +200,7 @@
]
},
"deploy-example-s4s2": {
"display_order": 9,
"display_order": 2,
"group": "example",
"materials": {
"example_repo": {
Expand Down Expand Up @@ -268,9 +268,9 @@
"rollback-example": {
"display_order": 1,
"environment_variables": {
"ALL_PIPELINE_FLAGS": "--pipeline=deploy-example-s4s --pipeline=deploy-example-de --pipeline=deploy-example-us --pipeline=deploy-example-customer-1 --pipeline=deploy-example-customer-2 --pipeline=deploy-example-customer-4 --pipeline=deploy-example-customer-7",
"ALL_PIPELINE_FLAGS": "--pipeline=deploy-example-s4s2 --pipeline=deploy-example-de --pipeline=deploy-example-us --pipeline=deploy-example-customer-1 --pipeline=deploy-example-customer-2 --pipeline=deploy-example-customer-4 --pipeline=deploy-example-customer-7",
"GOCD_ACCESS_TOKEN": "{{SECRET:[devinfra][gocd_access_token]}}",
"REGION_PIPELINE_FLAGS": "--pipeline=deploy-example-s4s --pipeline=deploy-example-de --pipeline=deploy-example-us --pipeline=deploy-example-customer-1 --pipeline=deploy-example-customer-2 --pipeline=deploy-example-customer-4 --pipeline=deploy-example-customer-7",
"REGION_PIPELINE_FLAGS": "--pipeline=deploy-example-s4s2 --pipeline=deploy-example-de --pipeline=deploy-example-us --pipeline=deploy-example-customer-1 --pipeline=deploy-example-customer-2 --pipeline=deploy-example-customer-4 --pipeline=deploy-example-customer-7",
"ROLLBACK_MATERIAL_NAME": "example_repo",
"ROLLBACK_STAGE": "example_stage",
"TRIGGERED_BY": ""
Expand Down
12 changes: 6 additions & 6 deletions test/testdata/goldens/pipedream/autodeploy-serial.jsonnet_output-files.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,8 @@
"display_order": 3,
"group": "example",
"materials": {
"deploy-example-s4s-pipeline-complete": {
"pipeline": "deploy-example-s4s",
"deploy-example-s4s2-pipeline-complete": {
"pipeline": "deploy-example-s4s2",
"stage": "pipeline-complete"
},
"example_repo": {
Expand Down Expand Up @@ -213,7 +213,7 @@
"format_version": 10,
"pipelines": {
"deploy-example-s4s": {
"display_order": 2,
"display_order": 9,
"group": "example",
"materials": {
"example_repo": {
Expand Down Expand Up @@ -251,7 +251,7 @@
"format_version": 10,
"pipelines": {
"deploy-example-s4s2": {
"display_order": 9,
"display_order": 2,
"group": "example",
"materials": {
"example_repo": {
Expand Down Expand Up @@ -333,9 +333,9 @@
"rollback-example": {
"display_order": 1,
"environment_variables": {
"ALL_PIPELINE_FLAGS": "--pipeline=deploy-example-s4s --pipeline=deploy-example-de --pipeline=deploy-example-us --pipeline=deploy-example-customer-1 --pipeline=deploy-example-customer-2 --pipeline=deploy-example-customer-4 --pipeline=deploy-example-customer-7",
"ALL_PIPELINE_FLAGS": "--pipeline=deploy-example-s4s2 --pipeline=deploy-example-de --pipeline=deploy-example-us --pipeline=deploy-example-customer-1 --pipeline=deploy-example-customer-2 --pipeline=deploy-example-customer-4 --pipeline=deploy-example-customer-7",
"GOCD_ACCESS_TOKEN": "{{SECRET:[devinfra][gocd_access_token]}}",
"REGION_PIPELINE_FLAGS": "--pipeline=deploy-example-s4s --pipeline=deploy-example-de --pipeline=deploy-example-us --pipeline=deploy-example-customer-1 --pipeline=deploy-example-customer-2 --pipeline=deploy-example-customer-4 --pipeline=deploy-example-customer-7",
"REGION_PIPELINE_FLAGS": "--pipeline=deploy-example-s4s2 --pipeline=deploy-example-de --pipeline=deploy-example-us --pipeline=deploy-example-customer-1 --pipeline=deploy-example-customer-2 --pipeline=deploy-example-customer-4 --pipeline=deploy-example-customer-7",
"ROLLBACK_MATERIAL_NAME": "example_repo",
"ROLLBACK_STAGE": "example_stage",
"TRIGGERED_BY": ""
Expand Down
12 changes: 6 additions & 6 deletions test/testdata/goldens/pipedream/autodeploy-serial.jsonnet_single-file.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,8 @@
"display_order": 3,
"group": "example",
"materials": {
"deploy-example-s4s-pipeline-complete": {
"pipeline": "deploy-example-s4s",
"deploy-example-s4s2-pipeline-complete": {
"pipeline": "deploy-example-s4s2",
"stage": "pipeline-complete"
},
"example_repo": {
Expand Down Expand Up @@ -187,7 +187,7 @@
]
},
"deploy-example-s4s": {
"display_order": 2,
"display_order": 9,
"group": "example",
"materials": {
"example_repo": {
Expand Down Expand Up @@ -220,7 +220,7 @@
]
},
"deploy-example-s4s2": {
"display_order": 9,
"display_order": 2,
"group": "example",
"materials": {
"example_repo": {
Expand Down Expand Up @@ -292,9 +292,9 @@
"rollback-example": {
"display_order": 1,
"environment_variables": {
"ALL_PIPELINE_FLAGS": "--pipeline=deploy-example-s4s --pipeline=deploy-example-de --pipeline=deploy-example-us --pipeline=deploy-example-customer-1 --pipeline=deploy-example-customer-2 --pipeline=deploy-example-customer-4 --pipeline=deploy-example-customer-7",
"ALL_PIPELINE_FLAGS": "--pipeline=deploy-example-s4s2 --pipeline=deploy-example-de --pipeline=deploy-example-us --pipeline=deploy-example-customer-1 --pipeline=deploy-example-customer-2 --pipeline=deploy-example-customer-4 --pipeline=deploy-example-customer-7",
"GOCD_ACCESS_TOKEN": "{{SECRET:[devinfra][gocd_access_token]}}",
"REGION_PIPELINE_FLAGS": "--pipeline=deploy-example-s4s --pipeline=deploy-example-de --pipeline=deploy-example-us --pipeline=deploy-example-customer-1 --pipeline=deploy-example-customer-2 --pipeline=deploy-example-customer-4 --pipeline=deploy-example-customer-7",
"REGION_PIPELINE_FLAGS": "--pipeline=deploy-example-s4s2 --pipeline=deploy-example-de --pipeline=deploy-example-us --pipeline=deploy-example-customer-1 --pipeline=deploy-example-customer-2 --pipeline=deploy-example-customer-4 --pipeline=deploy-example-customer-7",
"ROLLBACK_MATERIAL_NAME": "example_repo",
"ROLLBACK_STAGE": "example_stage",
"TRIGGERED_BY": ""
Expand Down
16 changes: 8 additions & 8 deletions ...estdata/goldens/pipedream/exclude-regions-autodeploy-parallel.jsonnet_output-files.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"format_version": 10,
"pipelines": {
"deploy-example-customer-1": {
"display_order": 3,
"display_order": 4,
"group": "example",
"materials": {
"example_repo": {
Expand Down Expand Up @@ -41,7 +41,7 @@
"format_version": 10,
"pipelines": {
"deploy-example-customer-2": {
"display_order": 4,
"display_order": 5,
"group": "example",
"materials": {
"example_repo": {
Expand Down Expand Up @@ -79,7 +79,7 @@
"format_version": 10,
"pipelines": {
"deploy-example-customer-4": {
"display_order": 5,
"display_order": 6,
"group": "example",
"materials": {
"example_repo": {
Expand Down Expand Up @@ -117,7 +117,7 @@
"format_version": 10,
"pipelines": {
"deploy-example-customer-7": {
"display_order": 6,
"display_order": 7,
"group": "example",
"materials": {
"example_repo": {
Expand Down Expand Up @@ -155,7 +155,7 @@
"format_version": 10,
"pipelines": {
"deploy-example-de": {
"display_order": 2,
"display_order": 3,
"group": "example",
"materials": {
"example_repo": {
Expand Down Expand Up @@ -193,7 +193,7 @@
"format_version": 10,
"pipelines": {
"deploy-example-s4s2": {
"display_order": 7,
"display_order": 2,
"group": "example",
"materials": {
"example_repo": {
Expand Down Expand Up @@ -233,9 +233,9 @@
"rollback-example": {
"display_order": 1,
"environment_variables": {
"ALL_PIPELINE_FLAGS": "--pipeline=deploy-example-de --pipeline=deploy-example-customer-1 --pipeline=deploy-example-customer-2 --pipeline=deploy-example-customer-4 --pipeline=deploy-example-customer-7",
"ALL_PIPELINE_FLAGS": "--pipeline=deploy-example-s4s2 --pipeline=deploy-example-de --pipeline=deploy-example-customer-1 --pipeline=deploy-example-customer-2 --pipeline=deploy-example-customer-4 --pipeline=deploy-example-customer-7",
"GOCD_ACCESS_TOKEN": "{{SECRET:[devinfra][gocd_access_token]}}",
"REGION_PIPELINE_FLAGS": "--pipeline=deploy-example-de --pipeline=deploy-example-customer-1 --pipeline=deploy-example-customer-2 --pipeline=deploy-example-customer-4 --pipeline=deploy-example-customer-7",
"REGION_PIPELINE_FLAGS": "--pipeline=deploy-example-s4s2 --pipeline=deploy-example-de --pipeline=deploy-example-customer-1 --pipeline=deploy-example-customer-2 --pipeline=deploy-example-customer-4 --pipeline=deploy-example-customer-7",
"ROLLBACK_MATERIAL_NAME": "example_repo",
"ROLLBACK_STAGE": "example_stage",
"TRIGGERED_BY": ""
Expand Down
16 changes: 8 additions & 8 deletions ...testdata/goldens/pipedream/exclude-regions-autodeploy-parallel.jsonnet_single-file.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"format_version": 10,
"pipelines": {
"deploy-example-customer-1": {
"display_order": 3,
"display_order": 4,
"group": "example",
"materials": {
"example_repo": {
Expand Down Expand Up @@ -35,7 +35,7 @@
]
},
"deploy-example-customer-2": {
"display_order": 4,
"display_order": 5,
"group": "example",
"materials": {
"example_repo": {
Expand Down Expand Up @@ -68,7 +68,7 @@
]
},
"deploy-example-customer-4": {
"display_order": 5,
"display_order": 6,
"group": "example",
"materials": {
"example_repo": {
Expand Down Expand Up @@ -101,7 +101,7 @@
]
},
"deploy-example-customer-7": {
"display_order": 6,
"display_order": 7,
"group": "example",
"materials": {
"example_repo": {
Expand Down Expand Up @@ -134,7 +134,7 @@
]
},
"deploy-example-de": {
"display_order": 2,
"display_order": 3,
"group": "example",
"materials": {
"example_repo": {
Expand Down Expand Up @@ -167,7 +167,7 @@
]
},
"deploy-example-s4s2": {
"display_order": 7,
"display_order": 2,
"group": "example",
"materials": {
"example_repo": {
Expand Down Expand Up @@ -202,9 +202,9 @@
"rollback-example": {
"display_order": 1,
"environment_variables": {
"ALL_PIPELINE_FLAGS": "--pipeline=deploy-example-de --pipeline=deploy-example-customer-1 --pipeline=deploy-example-customer-2 --pipeline=deploy-example-customer-4 --pipeline=deploy-example-customer-7",
"ALL_PIPELINE_FLAGS": "--pipeline=deploy-example-s4s2 --pipeline=deploy-example-de --pipeline=deploy-example-customer-1 --pipeline=deploy-example-customer-2 --pipeline=deploy-example-customer-4 --pipeline=deploy-example-customer-7",
"GOCD_ACCESS_TOKEN": "{{SECRET:[devinfra][gocd_access_token]}}",
"REGION_PIPELINE_FLAGS": "--pipeline=deploy-example-de --pipeline=deploy-example-customer-1 --pipeline=deploy-example-customer-2 --pipeline=deploy-example-customer-4 --pipeline=deploy-example-customer-7",
"REGION_PIPELINE_FLAGS": "--pipeline=deploy-example-s4s2 --pipeline=deploy-example-de --pipeline=deploy-example-customer-1 --pipeline=deploy-example-customer-2 --pipeline=deploy-example-customer-4 --pipeline=deploy-example-customer-7",
"ROLLBACK_MATERIAL_NAME": "example_repo",
"ROLLBACK_STAGE": "example_stage",
"TRIGGERED_BY": ""
Expand Down
20 changes: 12 additions & 8 deletions .../testdata/goldens/pipedream/exclude-regions-autodeploy-serial.jsonnet_output-files.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"format_version": 10,
"pipelines": {
"deploy-example-customer-1": {
"display_order": 3,
"display_order": 4,
"group": "example",
"materials": {
"deploy-example-de-pipeline-complete": {
Expand Down Expand Up @@ -45,7 +45,7 @@
"format_version": 10,
"pipelines": {
"deploy-example-customer-2": {
"display_order": 4,
"display_order": 5,
"group": "example",
"materials": {
"deploy-example-customer-1-pipeline-complete": {
Expand Down Expand Up @@ -87,7 +87,7 @@
"format_version": 10,
"pipelines": {
"deploy-example-customer-4": {
"display_order": 5,
"display_order": 6,
"group": "example",
"materials": {
"deploy-example-customer-2-pipeline-complete": {
Expand Down Expand Up @@ -129,7 +129,7 @@
"format_version": 10,
"pipelines": {
"deploy-example-customer-7": {
"display_order": 6,
"display_order": 7,
"group": "example",
"materials": {
"deploy-example-customer-4-pipeline-complete": {
Expand Down Expand Up @@ -171,9 +171,13 @@
"format_version": 10,
"pipelines": {
"deploy-example-de": {
"display_order": 2,
"display_order": 3,
"group": "example",
"materials": {
"deploy-example-s4s2-pipeline-complete": {
"pipeline": "deploy-example-s4s2",
"stage": "pipeline-complete"
},
"example_repo": {
"branch": "master",
"destination": "example",
Expand Down Expand Up @@ -209,7 +213,7 @@
"format_version": 10,
"pipelines": {
"deploy-example-s4s2": {
"display_order": 7,
"display_order": 2,
"group": "example",
"materials": {
"example_repo": {
Expand Down Expand Up @@ -249,9 +253,9 @@
"rollback-example": {
"display_order": 1,
"environment_variables": {
"ALL_PIPELINE_FLAGS": "--pipeline=deploy-example-de --pipeline=deploy-example-customer-1 --pipeline=deploy-example-customer-2 --pipeline=deploy-example-customer-4 --pipeline=deploy-example-customer-7",
"ALL_PIPELINE_FLAGS": "--pipeline=deploy-example-s4s2 --pipeline=deploy-example-de --pipeline=deploy-example-customer-1 --pipeline=deploy-example-customer-2 --pipeline=deploy-example-customer-4 --pipeline=deploy-example-customer-7",
"GOCD_ACCESS_TOKEN": "{{SECRET:[devinfra][gocd_access_token]}}",
"REGION_PIPELINE_FLAGS": "--pipeline=deploy-example-de --pipeline=deploy-example-customer-1 --pipeline=deploy-example-customer-2 --pipeline=deploy-example-customer-4 --pipeline=deploy-example-customer-7",
"REGION_PIPELINE_FLAGS": "--pipeline=deploy-example-s4s2 --pipeline=deploy-example-de --pipeline=deploy-example-customer-1 --pipeline=deploy-example-customer-2 --pipeline=deploy-example-customer-4 --pipeline=deploy-example-customer-7",
"ROLLBACK_MATERIAL_NAME": "example_repo",
"ROLLBACK_STAGE": "example_stage",
"TRIGGERED_BY": ""
Expand Down
Loading
Loading