Add colima VM diskspace check #218
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
chromy
force-pushed
the
chromy/2026-01-19-check-disk-space
branch
2 times, most recently
from
bd3355a to
7ff5777
Compare
runningcode
approved these changes
Jan 19, 2026
runningcode
reviewed
Jan 19, 2026
| @checker | ||
| def check() -> tuple[bool, str]: | ||
| status = colima.check() | ||
| if status != colima.ColimaStatus.UP: |
There was a problem hiding this comment.
I'm not sure what the Colima status was when this happened. I assume this exits early if colima reports that it is up?
runningcode
approved these changes
Jan 19, 2026
runningcode
left a comment
runningcode
left a comment
There was a problem hiding this comment.
LGTM, just had one question on the PR
joshuarli
force-pushed
the
chromy/2026-01-19-check-disk-space
branch
from
7ff5777 to
68e62b3
Compare
joshuarli
reviewed
Jan 26, 2026
Member
joshuarli
left a comment
joshuarli
left a comment
There was a problem hiding this comment.
colima VM's disk is copy-on-write, so even if you resize the disk to some higher amount it's likely the host disk runs out before your VM disk free % detection works
it'll be better to initially provision a large disk equal to the host's disk then simply check the host's disk free rather than the VM's
i'll rework this PR!
Member
|
superseded by #219 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An error at least @runningcode and I have encountered is colima running out of disk space.
This adds a
devenv doctorcheck to suggest a resolution to the dev.