Skip to content

ci(release): Switch from action-prepare-release to Craft #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BYK wants to merge 13 commits into
base: main
Choose a base branch
from
+25 −3
Open

ci(release): Switch from action-prepare-release to Craft #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
aba74b7
ci(release): Switch from action-prepare-release to Craft
BYK Jan 9, 2026
2cd9491
ci(release): Restore GitHub App token authentication
BYK Jan 9, 2026
55e938f
fix: Pin actions to SHA and add permissions blocks
BYK Jan 10, 2026
da506c9
fix: Use correct action version SHAs (restore original versions)
BYK Jan 10, 2026
f9039e7
fix: Use correct action version SHAs (restore original versions)
BYK Jan 10, 2026
ad6aaf6
fix: Clean up action version comments
BYK Jan 12, 2026
cb3ed68
Update Craft SHA to 1c58bfd57bfd6a967b6f3fc92bead2c42ee698ce
BYK Jan 13, 2026
0b6b135
Add explicit permissions block to build.yml
BYK Jan 13, 2026
d72cbec
Revert permissions changes to build.yml
BYK Jan 13, 2026
dd2f6cd
fix: revert extraneous changes to non-release workflow files
BYK Jan 13, 2026
1a9cd99
fix: clean up release.yml formatting and version comments
BYK Jan 14, 2026
ae532d0
build(craft): Update Craft action to c6e2f04
BYK Jan 14, 2026
31fa4e0
chore: add unlabeled trigger to changelog-preview
BYK Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/changelog-preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
name: Changelog Preview
on:
pull_request:
types:
- opened
- synchronize
- reopened
- edited
- labeled
- unlabeled
permissions:
contents: write
pull-requests: write

jobs:
changelog-preview:
uses: getsentry/craft/.github/workflows/changelog-preview.yml@v2
secrets: inherit
10 changes: 7 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,15 @@ on:
workflow_dispatch:
inputs:
version:
description: Version to release
required: true
description: Version to release (or "auto")
required: false
force:
description: Force a release even when there are release-blockers (optional)
required: false
permissions:
contents: write
pull-requests: write

jobs:
release:
runs-on: ubuntu-latest
Expand All @@ -25,7 +29,7 @@ jobs:
token: ${{ steps.token.outputs.token }}
fetch-depth: 0
- name: Prepare release
uses: getsentry/action-prepare-release@v1
uses: getsentry/craft@c6e2f04939b6ee67030588afbb5af76b127d8203 # v2
env:
GITHUB_TOKEN: ${{ steps.token.outputs.token }}
Copy link

@sentry sentry bot Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: When the optional version input is not provided, an empty string is passed to the release action, which may not be handled as the expected "auto" value.
Severity: MEDIUM

Suggested Fix

Verify if the getsentry/craft action correctly handles an empty string for its version input. If it requires the literal string "auto", consider setting default: 'auto' for the workflow input to ensure the correct value is passed when none is provided.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: .github/workflows/release.yml#L34

Potential issue: The `release.yml` workflow's `version` input was changed to be
optional. When a user triggers this workflow without providing a `version`, GitHub
Actions passes an empty string (`""`) to the `getsentry/craft` action. The input's
description, "(or 'auto')", suggests that the literal string `"auto"` might be the
expected value for automatic versioning. If the `craft` action does not treat an empty
string as equivalent to `"auto"`, the release process may fail when no version is
specified.

Did we get this right? 👍 / 👎 to inform future reviews.

with:
Expand Down