Open
Conversation
davidtsuk
commented
May 1, 2025
| } | ||
|
|
||
| fn submit(&mut self, message: Message<TPayload>) -> Result<(), SubmitError<TPayload>> { | ||
| self.iterations_since_last_submit = 0; |
Contributor
Author
There was a problem hiding this comment.
not sure if we should check if submit was successful before reseting this counter
davidtsuk
commented
May 1, 2025
| path: PathBuf, | ||
| interval: Duration, | ||
| deadline: SystemTime, | ||
| iterations_since_last_submit: u64, |
Contributor
Author
There was a problem hiding this comment.
I'm using a u64, but maybe we can get away with a u32
evanh
approved these changes
May 2, 2025
Contributor
|
As this is something you are testing for the Snuba consumer I would do this inside the snuba consumer code rather than the standard HealthCheck in the arroyo code base. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of touching the health file every time we call poll, we only touch it when one of the following two conditions is true: