Preserve string column values that look like datetimes#7646
Open
nmosafi wants to merge 1 commit intogetredash:masterfrom
Open
Preserve string column values that look like datetimes#7646nmosafi wants to merge 1 commit intogetredash:masterfrom
nmosafi wants to merge 1 commit intogetredash:masterfrom
Conversation
The frontend type-sniffing logic converts datetime-looking strings to moment objects, which only support millisecond precision. Values with sub-millisecond precision (e.g. nanosecond timestamps like "2026-02-23T15:00:01.308267939") lose their fractional digits. When the backend explicitly sets the column type to "string", the frontend now respects that and skips the datetime/date conversion, displaying the original value as-is. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The frontend type-sniffing logic converts datetime-looking strings to moment objects, which only support millisecond precision. Values with sub-millisecond precision (e.g. nanosecond timestamps like "2026-02-23T15:00:01.308267939") lose their fractional digits.
When the backend explicitly sets the column type to "string", the frontend now respects that and skips the datetime/date conversion, displaying the original value as-is.
What type of PR is this?
Description
How is this tested?
Tested by running some queries against our Trino instance. I see
2026-02-23T15:00:01.308267939displayed completely now, whereas before it would display as23/02/26 15:00Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)