Skip to content

Comments

feat: Rework GitHub action with goreleaser#32

Draft
yodamad wants to merge 1 commit intomainfrom
feat/goreleaser
Draft

feat: Rework GitHub action with goreleaser#32
yodamad wants to merge 1 commit intomainfrom
feat/goreleaser

Conversation

@yodamad
Copy link
Collaborator

@yodamad yodamad commented Feb 4, 2026

Fix #27

Need to setup a GH_TOKEN on project with rights to write to plumber and homebrew-plumber for goreleaser to be able to push binaries and infos

Review and rework if needed release.yaml also

@Joseph94m
Copy link
Collaborator

Joseph94m commented Feb 5, 2026

I don't know github actions enough to evaluate this simply from reading. I need to ensure the following:

  • Release lifecycle only updates patches: we want to stay in the v0.1.X for now.
  • The generation and embedding of the default configuration file default.yaml in https://github.com/getplumber/plumber/tree/main/internal/defaultconfig must not be lost during this migration
  • All the binary formats (windows, arm, amd, linux, macos), their checksums, names and paths must remain the same
  • docker images must be pushed with 4 images: latest, 0, 0.1 and 0.1.x
  • New tap formula must be pushed on every release: latest must be updated + 1 file for pinned keg version
  • Use GITHUB_TOKEN instead of GH_TOKEN

@yodamad
Copy link
Collaborator Author

yodamad commented Feb 7, 2026

Almost everything you explained is covered by goreleaser (not by github actions)
I've kept the docker part you've made befire, the only point it the stuff about the configuration file (not sure to understand why it should be done)

Regarding the token, it is a secret necessary for goreleaser, i've called it GH_TOKEN, but it could BLABLA_TOKEN also

@thomasboni
Copy link
Contributor

cursor review verbose=true

@cursor
Copy link

cursor bot commented Feb 17, 2026

Bugbot request id: serverGenReqId_f87dfb02-130a-4320-855a-eaa5c9baeb87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CHORE] Migrate github action brew formula updater

3 participants