[FEATURE] Implement open state and group mode for details shortcode#79
Open
schliflo wants to merge 1 commit intogetgrav:developfrom
Open
[FEATURE] Implement open state and group mode for details shortcode#79schliflo wants to merge 1 commit intogetgrav:developfrom
schliflo wants to merge 1 commit intogetgrav:developfrom
Conversation
Member
|
Details is supposed to be a simple 'javascript' free solution. It seems you are trying to implement an accordion, which already has an open state and is by default 'grouped'. Is there a reason you are trying to make 'details' behave like 'accordion' ? |
Author
|
That's exactly what I'm trying to do. I'd be happy to reduce the PR to only implement the configurable open state - which should be configurable even if it's not used as an accordion. |
Member
|
OK, I get it, as this is a more 'accessible' accordion solution, might it not be better to use |
Member
|
Just found this: https://www.scottohara.me/blog/2018/09/03/details-and-summary.html which is basically exactly what you are trying to do? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables users to manually set details to open.
Additionally via group mode, you can group items to achieve real accordion like behaviour.