fix: update nostr-tools and enable native auto-reconnect#516
Open
Dunsin-cyber wants to merge 2 commits intogetAlby:masterfrom
Open
fix: update nostr-tools and enable native auto-reconnect#516Dunsin-cyber wants to merge 2 commits intogetAlby:masterfrom
Dunsin-cyber wants to merge 2 commits intogetAlby:masterfrom
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
|
Thanks @Dunsin-cyber , this is a great improvement I think! I need to test it heavily and will provide a more detailed review once I have done so. It might take some time to get to this because the current setup "is working" and we are currently doing some more higher impact explorations right now. |
Contributor
Author
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @rolznz, Happy New Year! 🎉
I noticed this issue #503 has been open for a couple of months, so I figured I’d take a crack at it to help move things along.
I've put together a fix that moves us away from the manual retry loops and leans into the newer
nostr-toolsfeatures discussed here nbd-wtf/nostr-tools#513.What I did:
enableReconnect: trueto theSimplePoolin the constructor.whileretry loops inNWCClient,NWAClient, andNWCWalletService. We now just subscribe once and let the library handle staying connected.NWCWalletServiceto handle an array of relays for better redundancy._checkConnectedto useensureRelayso the SDK actively tries to heal all connections instead of just settling for one.