Refactor : enhanced readability of the code#349
Refactor : enhanced readability of the code#349guptamukund22 wants to merge 5 commits intogetAlby:masterfrom
Conversation
guptamukund22
commented
Apr 3, 2025
guptamukund22
commented
- Refactored "OauthWeblnProvider.ts" by implementing "execute" method for better readability and modularity.
guptamukund22
changed the title
|
#344 moves some code around. once that one is merged maybe you can update this one again and we'll review it. thanks |
|
Hi @guptamukund22 could you please make sure to branch off master before making each change, so you don't have changes from the previous PR in this one too. Sorry for the conflicts - we just merged the big change Bumi mentioned above. |
|
@guptamukund22 can you please try to resolve the conflicts and then i can review it again thanks! |
| request_options?: Partial<RequestOptions>, | ||
| ): Promise<GetAccountBalanceResponse> { | ||
| // HTTP handlers | ||
| private httpGet<T>( |
There was a problem hiding this comment.
instead of having httpGet httpPost httpDelete methods. can we have generic http Request method here?
There was a problem hiding this comment.
Sure, Actually I have my end semester exams going on that's why I was not able to reply. I will fix the issue asap.
| accountInformation( | ||
| // eslint-disable-next-line @typescript-eslint/ban-types | ||
| params: {}, | ||
| request_options?: Partial<RequestOptions>, |
There was a problem hiding this comment.
why params and request_options from all the methods were removed. this will break things for package users. we should refactor but not change current working of library
4 participants
