fix: force qr code colors to light theme#430
Conversation
📝 WalkthroughWalkthroughFixed QR code color display in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
components/QRCode.tsx (1)
55-56: Force the avatar overlay background to light as well.
The QR area is now light-themed, but the avatar overlay still uses theme-drivenbg-background, which can be dark in dark mode and reduce QR contrast. Consider reusing the same lightbackgroundvalue here to keep scannability consistent.✅ Suggested tweak
- {showAvatar && ( - <View className="absolute self-center p-3 rounded-full bg-background"> + {showAvatar && ( + <View + className="absolute self-center p-3 rounded-full" + style={{ backgroundColor: background }} + >
Fixes #423
Utility > Design
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.