Implement NFC Tap-to-Pay for Lightning Payments#427
Open
GhanshyamJha05 wants to merge 1 commit intogetAlby:masterfrom
Open
Implement NFC Tap-to-Pay for Lightning Payments#427GhanshyamJha05 wants to merge 1 commit intogetAlby:masterfrom
GhanshyamJha05 wants to merge 1 commit intogetAlby:masterfrom
Conversation
- Add react-native-nfc-manager dependency - Configure Expo plugin and Android NFC permission - Create NFCScanner component for reading Lightning invoices from NFC tags - Integrate NFC scanning toggle in Send screen - Ensure compatibility with existing QR scanning and payment flows - Pass all tests and lint checks
Member
|
There's already a PR related to this here, @GhanshyamJha05 do you know how this compares to that? Did you test both PRs and get it to work? I'm not sure if your PR works well since the previous PR uses some workarounds (like plugins) to make it work, would appreciate if you can build on top of that (TODOs are mentioned) Also we appreciate concise human written PR/issue descriptions :) |
Author
|
Ok sir thanks for Feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Implement NFC Tap-to-Pay for Lightning Payments
Summary
This pull request introduces NFC (Near Field Communication) support to Alby Go, enabling users to pay Lightning invoices by tapping their device against NFC-enabled terminals or tags. This adds a contactless payment method alongside the existing QR code scanning, enhancing the user experience for in-person transactions.
Motivation
Implementation Details
react-native-nfc-managerfor cross-platform NFC handling, configured via Expo plugin for managed workflow compatibility.app.config.js.NFCScanner.tsxto detect NFC tags, parse NDEF records containing Lightning invoices (BOLT11 or LNURL), and trigger payment flows.Testing & Validation
Files Changed
app.config.js: Added NFC plugin and permissions.components/NFCScanner.tsx: New NFC scanning component.pages/send/Send.tsx: UI toggle for NFC/QR modes.package.json&package-lock.json: Dependency updates.Impact
This is a major, self-contained enhancement that advances Alby Go's capabilities while contributing to broader Bitcoin infrastructure goals. Estimated development time: 8-12 weeks for a skilled developer. Ready for review and potential inclusion in upcoming releases.
Closes #426 (related to multi-language support, but NFC complements localization efforts by enabling global payment methods).