SQL: Allow database name and schema be specified for each model#147
Closed
salieri wants to merge 2 commits intogeddy:masterfrom
Closed
SQL: Allow database name and schema be specified for each model#147salieri wants to merge 2 commits intogeddy:masterfrom
salieri wants to merge 2 commits intogeddy:masterfrom
Conversation
Contributor
|
This looks good. Similar work is happening here: #151 Would it be possible for y'all to coordinate to make sure this stuff plays nicely together? |
Author
|
By the looks of it, for a successful merge all that's needed is for me to go over the tableizeModelName() calls and make sure they use tableizeModelNameFull() instead where appropriate. Should not be a problem at all. |
Contributor
|
Where are we on this? Can y'all get this sorted out, or do I need to do separate merges and then sort it out? |
Author
|
Will get back to you after crunch mode is over, give it a few weeks. |
Contributor
|
Excellent. :) Lemme know if there's anything I can do to help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In larger applications, data is often divided between schemas and databases.
This change allows developers to define schema and database for each model that uses Postgres or MySQL database adapters. (Schemas only supported on Postgres.)
Interface is simple -- when defining a model, just add "db" and/or "schema" values: