-
Notifications
You must be signed in to change notification settings - Fork 41
add agents #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
add agents #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's GuideUpdates the project to gdsfactory 9.34, introduces an automated Claude-based PR review workflow and AGENTS guidelines, and removes legacy GitHub automation for required labels and Dependabot. Sequence diagram for Claude PR review workflow triggers and interactionssequenceDiagram
actor Developer
participant GitHub
participant Claude_PR_Workflow
participant Claude_Code_Action
participant Anthropic_API
Developer->>GitHub: Open or update pull_request
GitHub-->>Claude_PR_Workflow: Trigger claude-pr-review (pull_request event)
Claude_PR_Workflow->>Claude_Code_Action: Run anthropics/claude-code-action@beta
Claude_Code_Action->>GitHub: Read PR diff, files, comments
Claude_Code_Action->>Anthropic_API: Send review request (model claude-sonnet-4-20250514)
Anthropic_API-->>Claude_Code_Action: Return review feedback
Claude_Code_Action->>GitHub: Post PR review comments
Developer->>GitHub: Add issue_comment with @claude on PR
GitHub-->>Claude_PR_Workflow: Trigger claude-pr-review (issue_comment event)
Claude_PR_Workflow->>Claude_Code_Action: Run anthropics/claude-code-action@beta
Claude_Code_Action->>GitHub: Read PR context for comment
Claude_Code_Action->>Anthropic_API: Send follow-up review request
Anthropic_API-->>Claude_Code_Action: Return updated feedback
Claude_Code_Action->>GitHub: Post additional comments on PR
Flow diagram for PR lifecycle with Claude review and removed label requirementflowchart TD
A["Developer opens or updates PR"] --> B["GitHub triggers claude-pr-review workflow"]
B --> C["Checkout repository (actions/checkout@v4)"]
C --> D["Run anthropics/claude-code-action@beta"]
D --> E["Claude reads PR changes and AGENTS.md guidelines"]
E --> F["Claude sends analysis request to Anthropic API"]
F --> G["Anthropic returns review feedback"]
G --> H["Claude posts review comments on PR"]
H --> I{"Developer updates code?"}
I -->|Yes| A
I -->|No| J["PR ready for human maintainer review and merge"]
%% Removed legacy steps
J --> K["No automatic required-label check (require-labels.yml removed)"]
J --> L["No Dependabot automation (dependabot.yml removed)"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- Consider pinning
anthropics/claude-code-actionto a specific version or tag instead of@betato avoid unexpected behavior changes from upstream updates. - The
claude-pr-reviewjob currently hasissues: writeandid-token: writepermissions; if the action doesn’t actually need these capabilities, tightening the permissions to the minimum required would reduce the workflow’s security surface.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider pinning `anthropics/claude-code-action` to a specific version or tag instead of `@beta` to avoid unexpected behavior changes from upstream updates.
- The `claude-pr-review` job currently has `issues: write` and `id-token: write` permissions; if the action doesn’t actually need these capabilities, tightening the permissions to the minimum required would reduce the workflow’s security surface.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
ThomasPluck
approved these changes
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Update dependencies and CI workflows while introducing AI-assisted code review and coding standards documentation.
New Features:
Enhancements:
CI:
Documentation:
Chores: