Skip to content

feat: add sim-data- prefix to download dir and trame dependencies #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vvahidd merged 1 commit into from
Feb 5, 2026
Merged

feat: add sim-data- prefix to download dir and trame dependencies #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Simulation outputs
sim-data-*/
palace-sim-*/
dev-palace-simulation-*/

# files
*.c
Expand Down
10 changes: 5 additions & 5 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,23 +6,23 @@ requires = ["setuptools>=61", "uv", "build", "wheel"]
authors = [{name = "GDSFactory", email = "contact@gdsfactory.com"}]
classifiers = [
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
"Programming Language :: Python :: 3.14",
"Operating System :: OS Independent"
]
dependencies = [
"gdsfactory>=9.32.0",
"gdsfactoryplus>=1.3.12",
"gdsfactoryplus>=1.4.0",
"gmsh",
"meshio>=5.0.0",
"plotly",
"pydantic>=2.10.6",
"pyvista>=0.43.0"
"pyvista>=0.43.0",
"trame-vtk",
"trame-vuetify"
]
description = ""
name = "gsim"
readme = "README.md"
requires-python = ">=3.12"
requires-python = "~=3.12.0"
version = "0.0.3"

[project.optional-dependencies]
Expand Down
4 changes: 3 additions & 1 deletion src/gsim/gcloud.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,9 @@ def run_simulation(
_handle_failed_job(finished_job, output_dir, verbose)

# Download
raw_results = sim.download_results(finished_job)
raw_results = sim.download_results(
finished_job, output_dir=f"sim-data-{finished_job.job_name}"
)

# Flatten results: gdsfactoryplus returns extracted directories,
# but we want a dict of filename -> Path for individual files
Expand Down
Loading