Merged
Conversation
- Rename validate() to validate_config() to avoid Pydantic conflict - Rename type parameter to material_type to avoid shadowing builtin - Add type: ignore comments for duck-typed code patterns - Sort __all__ lists alphabetically (ruff I001) - Flatten nested conditionals and use comprehensions - Add logger to viz.py for non-notebook feedback - Clean up notebooks (cell IDs, remove empty cells) - Update tests for renamed methods Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate()tovalidate_config()on simulation classes to avoid conflict with Pydantic's built-in methodtypeparameter tomaterial_typeinset_material()to avoid shadowing Python builtin# type: ignorecomments for duck-typed code patterns (e.g., afterhasattr()checks)__all__lists alphabetically per ruff I001viz.pyfor user feedback when not in notebookBreaking Changes
sim.validate()→sim.validate_config()sim.set_material("metal", type="conductor")→sim.set_material("metal", material_type="conductor")Test plan
🤖 Generated with Claude Code