Skip to content

update gdsfactory9.34#202

Merged
joamatab merged 2 commits intomainfrom
update_gdsfactory9.34
Feb 3, 2026
Merged

update gdsfactory9.34#202
joamatab merged 2 commits intomainfrom
update_gdsfactory9.34

Conversation

@joamatab
Copy link
Contributor

@joamatab joamatab commented Feb 3, 2026

  • add_code_owners
  • update_gdsfactory9.34

Summary by Sourcery

Bump the gdsfactory dependency and refresh si220_cband netlist fixtures to align with the new netlisting behavior and naming conventions.

Build:

  • Update gdsfactory dependency to ~=9.34.0 in pyproject.toml.

Tests:

  • Regenerate and simplify si220_cband YAML netlist fixtures (spirals, racetrack, rings, fiber arrays, vias, text, die and primitives) to use new instance names, placements, nets, ports, and to drop obsolete top-level name fields where no instances are present.

@sourcery-ai
Copy link

sourcery-ai bot commented Feb 3, 2026

Reviewer's Guide

Updates to support gdsfactory 9.34: dependency bump plus regenerated golden netlist YAMLs to match new naming/serialization conventions (shorter instance names, reordered/added instances, nets, placements, and ports).

Flow diagram for netlist regression tests with updated gdsfactory 9_34

flowchart LR
  A[Start_tests] --> B[Import_gdsfactory_9_34_0]
  B --> C[Generate_component_netlists]
  C --> D[Load_golden_netlist_YAMLs]
  D --> E[Normalize_and_compare_netlists]
  E --> F{Match}
  F -- Yes --> G[Test_passes]
  F -- No --> H[Test_fails]
  G --> I[End_tests]
  H --> I[End_tests]
Loading

File-Level Changes

Change Details Files
Bump core PDK dependency to gdsfactory 9.34.0.
  • Update gdsfactory version constraint from 9.29.1 to 9.34.0 in pyproject dependencies.
  • Leave other dependencies (gplugins, doroutes) unchanged.
pyproject.toml
Regenerate spiral and spiral_racetrack golden netlists to reflect new instance naming and connectivity from gdsfactory 9.34.
  • Replace long auto-generated instance keys for bends/straights with short sequential names (bend_euler, bend_euler2..., straight, straight2...).
  • Update nets arrays to refer to the new instance identifiers while preserving connectivity topology.
  • Adjust placements blocks to match new instance names and any updated positions/rotations coming from the regenerated layouts.
  • Update top-level ports to reference the renamed instances.
tests/test_si220_cband/test_netlists_spiral_.yml
tests/test_si220_cband/test_netlists_spiral_racetrack_.yml
Regenerate golden netlists for several composed components to use new instance names and port references.
  • For add_fiber_array, ring_single, ring_double, via_stack_heater_mtop, text_rectangular_multi_layer, die: rename internal instances to short logical names (e.g., bend_euler, coupler_ring, compass, rectangle, text_rectangular).
  • Update nets sections to use the new instance keys where connectivity exists.
  • Update placements and ports sections to point to the renamed instances while preserving geometry and external interface names.
tests/test_si220_cband/test_netlists_add_fiber_array_.yml
tests/test_si220_cband/test_netlists_ring_single_.yml
tests/test_si220_cband/test_netlists_ring_double_.yml
tests/test_si220_cband/test_netlists_via_stack_heater_mtop_.yml
tests/test_si220_cband/test_netlists_text_rectangular_multi_layer_.yml
tests/test_si220_cband/test_netlists_die_.yml
Simplify or remove redundant top-level "name" fields from single-component YAML netlists now empty/structural.
  • Drop the name field from many trivial netlist fixtures that only validated component naming (e.g., bend_euler, bend_metal, straight, pad, text_rectangular).
  • Keep instances/nets/placements/ports structures otherwise unchanged (mostly empty).
  • Update mzi netlist to remove only the top-level name while preserving its full internal instance graph.
tests/test_si220_cband/test_netlists_bend_euler_.yml
tests/test_si220_cband/test_netlists_bend_metal_.yml
tests/test_si220_cband/test_netlists_bend_s_.yml
tests/test_si220_cband/test_netlists_bend_s_metal_.yml
tests/test_si220_cband/test_netlists_compass_.yml
tests/test_si220_cband/test_netlists_coupler_.yml
tests/test_si220_cband/test_netlists_coupler_rib_.yml
tests/test_si220_cband/test_netlists_coupler_ring_.yml
tests/test_si220_cband/test_netlists_crossing_.yml
tests/test_si220_cband/test_netlists_crossing_rib_.yml
tests/test_si220_cband/test_netlists_grating_coupler_elliptical_.yml
tests/test_si220_cband/test_netlists_grating_coupler_rectangular_.yml
tests/test_si220_cband/test_netlists_grating_coupler_rectangular_rib_.yml
tests/test_si220_cband/test_netlists_heater_.yml
tests/test_si220_cband/test_netlists_mmi1x2_.yml
tests/test_si220_cband/test_netlists_mmi1x2_rib_.yml
tests/test_si220_cband/test_netlists_mmi2x2_.yml
tests/test_si220_cband/test_netlists_mmi2x2_rib_.yml
tests/test_si220_cband/test_netlists_mzi_.yml
tests/test_si220_cband/test_netlists_pad_.yml
tests/test_si220_cband/test_netlists_rectangle_.yml
tests/test_si220_cband/test_netlists_straight_.yml
tests/test_si220_cband/test_netlists_straight_heater_meander_.yml
tests/test_si220_cband/test_netlists_straight_heater_metal_.yml
tests/test_si220_cband/test_netlists_straight_metal_.yml
tests/test_si220_cband/test_netlists_straight_rib_.yml
tests/test_si220_cband/test_netlists_straight_strip_.yml
tests/test_si220_cband/test_netlists_taper_.yml
tests/test_si220_cband/test_netlists_taper_metal_.yml
tests/test_si220_cband/test_netlists_taper_strip_to_ridge_.yml
tests/test_si220_cband/test_netlists_text_rectangular_.yml
tests/test_si220_cband/test_netlists_trans_rib10_.yml
tests/test_si220_cband/test_netlists_trans_rib20_.yml
tests/test_si220_cband/test_netlists_trans_rib50_.yml
tests/test_si220_cband/test_netlists_wire_corner45_.yml
tests/test_si220_cband/test_netlists_wire_corner45_straight_.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@joamatab joamatab added the dependencies Pull requests that update a dependency file label Feb 3, 2026
@joamatab joamatab merged commit 582a9b4 into main Feb 3, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant