allow zero length straight rings

[joamatab]

• remove samples from wheel
• add_version

Summary by Sourcery

Allow ring_single components to support zero-length straight segments without causing port overlap issues in both C-band and O-band libraries.

New Features:

• Support ring_single configurations where horizontal and/or vertical straight segment lengths are zero by constructing a custom component topology instead of delegating to the generic factory.

Bug Fixes:

• Prevent port overlap and invalid geometry when ring_single is called with zero-length straight segments in C-band and O-band cells.

[sourcery-ai]

Reviewer's Guide

Special-cases ring_single implementations in both si220 cband and oband to correctly build ring layouts when horizontal or vertical straight sections have zero length, avoiding port overlap and preserving ring coupler behavior.

Sequence diagram for constructing ring_single with zero-length straights

sequenceDiagram
  participant Caller
  participant ring_single
  participant gf
  participant Component_c
  Caller->>ring_single: ring_single(gap, radius, length_x, length_y, cross_section, length_extension)
  ring_single->>ring_single: check length_x == 0 or length_y == 0
  alt length_x == 0 or length_y == 0
    ring_single->>gf: get_component(coupler_ring, settings)
    gf-->>ring_single: coupler
    ring_single->>Component_c: create Component
    ring_single->>Component_c: place coupler as cb
    ring_single->>gf: get_component(bend_euler, cross_section, radius)
    gf-->>ring_single: bend
    ring_single->>Component_c: place bl and br
    ring_single->>ring_single: branch on length_x and length_y
    alt length_x == 0 and length_y == 0
      ring_single->>Component_c: connect bl.o2 to cb.o2
      ring_single->>Component_c: connect br.o2 to bl.o1
      ring_single->>Component_c: connect br.o1 to cb.o3
    else length_y == 0 and length_x != 0
      ring_single->>gf: get_component(straight, length_x, cross_section)
      gf-->>ring_single: straight_x
      ring_single->>Component_c: place st
      ring_single->>Component_c: connect bl.o2 to cb.o2
      ring_single->>Component_c: connect st.o2 to bl.o1
      ring_single->>Component_c: connect br.o2 to st.o1
      ring_single->>Component_c: connect br.o1 to cb.o3
    else length_x == 0 and length_y != 0
      ring_single->>gf: get_component(straight, length_y, cross_section)
      gf-->>ring_single: straight_y
      ring_single->>Component_c: place sl and sr
      ring_single->>Component_c: connect sl.o1 to cb.o2
      ring_single->>Component_c: connect bl.o2 to sl.o2
      ring_single->>Component_c: connect br.o2 to bl.o1
      ring_single->>Component_c: connect sr.o1 to br.o1
      ring_single->>Component_c: connect sr.o2 to cb.o3
    end
    ring_single->>Component_c: add ports o1,o2 from coupler ports
    ring_single->>Component_c: set info radius from coupler.info radius
    ring_single-->>Caller: Component_c
  else neither length_x nor length_y is zero
    ring_single->>gf: c.ring_single(gap, radius, length_x, length_y, cross_section, length_extension)
    gf-->>ring_single: component
    ring_single-->>Caller: component
  end

Loading

File-Level Changes

Change	Details	Files
Add explicit ring_single construction path for zero-length straight segments to avoid port overlap while maintaining correct routing and ports.	Detect cases where length_x or length_y is zero and bypass the generic gf.c.ring_single helper. Manually instantiate a coupler_ring with appropriate settings and place it into a new Component. Create left and right bend_euler bends and connect them and optional straight segments depending on which lengths are zero. Handle three subcases: both lengths zero, only vertical length zero (horizontal straight only), and only horizontal length zero (vertical straights only). Expose external ports by re-exporting coupler ports and propagate radius info from the coupler to the top-level component.	cspdk/si220/cband/cells/rings.py cspdk/si220/oband/cells/rings.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The zero-length handling logic in cband and oband is nearly identical; consider extracting a shared helper to avoid duplication and reduce the chance of the two implementations drifting out of sync.
• In the cband version settings includes length_extension but the oband version does not; if both bands should behave consistently for zero-length cases, double-check whether length_extension should also be passed in oband.
• You special-case length_x == 0 and length_y == 0 but don't guard against negative values; consider explicit validation or normalization of these parameters so the geometry and port layout remains well-defined for unexpected inputs.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The zero-length handling logic in cband and oband is nearly identical; consider extracting a shared helper to avoid duplication and reduce the chance of the two implementations drifting out of sync.
- In the cband version `settings` includes `length_extension` but the oband version does not; if both bands should behave consistently for zero-length cases, double-check whether `length_extension` should also be passed in oband.
- You special-case `length_x == 0` and `length_y == 0` but don't guard against negative values; consider explicit validation or normalization of these parameters so the geometry and port layout remains well-defined for unexpected inputs.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}