Move options for merging and rounding to profile.#5
Open
codingforfun wants to merge 1 commit intogdrius:masterfrom
Open
Move options for merging and rounding to profile.#5codingforfun wants to merge 1 commit intogdrius:masterfrom
codingforfun wants to merge 1 commit intogdrius:masterfrom
Conversation
Commandline still may override profile settings.
Contributor
Author
|
Hi, you don't like my ideas or just have no time for review? I really like your tool and changed some things to make it fit more to my individual use case. So I would really love to discuss some of the things I changed where I think they may also be useful for others or to improve the tool in general |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings for merging items and rounding could be very profile specific. I.e. if you wan't to export all activities belonging to a certain customer projects and they have their guidelines for rounding.
Therefor it makes sense to be able to specify them on a per profile basis to avoid mistakes and shorten the command line.
This PR moves setting for rounding and merging of entries into profile settings.
Commandline still may override profile settings.