merging up to 1.7.1 #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've added NSLocalizedString to support internal title's translation
Translate internal title
- Fix Kingfisher integration for latest version - Replace CompletionHandler with new Result type
This reverts commit d0dd718.
Fix Kingfisher Integration
By assigning the new photoIndex to self.currentPhotoIndex, the following assertion and crash scenario is fixed: 1. Host app creates an `AXPhotosViewController` and calls `navigateToPhotoIndex(index, animated: false)` on it, where index > 0 2. Host app presents `AXPhotosViewController` 3. User does not swipe left or right, but just dismisses the photo view 4. Assertion "Unable to resolve some necessary properties in order to transition. [...]" fails, and on a non-debug build the app crashes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.