feat(based-op-reth): execute_frag on state machine #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamungkaski
commented
Dec 19, 2025
| } | ||
|
|
||
| /// Looks up and returns a cloned transaction by transaction hash, if present. | ||
| pub fn get_transaction(&self, tx_hash: &TxHash) -> Option<Transaction> { |
Collaborator
Author
There was a problem hiding this comment.
I could make a HashMap with TxHash and Transaction if needed
pamungkaski
commented
Dec 19, 2025
|
|
||
| /// Returns the canonical block number. | ||
| pub fn canonical_block_number(&self) -> u64 { | ||
| // TODO: Is this correct? |
pamungkaski
commented
Dec 19, 2025
| self.receipts.extend_from_slice(receipts.as_slice()); | ||
| self.cumulative_gas_used = cummulative_gas_used; | ||
|
|
||
| // TODO: Is this correct? Is everything applied here? |
Collaborator
Author
There was a problem hiding this comment.
most is applied here, transaction list and db cache are applied separately but called before this
…reth/state_executor
Co-authored-by: Ki Ageng Satria Pamungkas <ageng.satria@bukalapak.com> Co-authored-by: Jonas Bostoen <jonasbostoen@fastmail.com>
… on SealFragsV0 (#274) Co-authored-by: Ki Ageng Satria Pamungkas <ageng.satria@bukalapak.com> Co-authored-by: Jonas Bostoen <jonasbostoen@fastmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.