feat: Convert CircleCI workflows to GitHub Actions workflows #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert CircleCI workflows to GitHub Actions workflows. * Add `.github/workflows/ci.yml` to define GitHub Actions workflows for dependency caching, testing, analysis, and publishing. * Use a matrix to test with Node.js versions 18, 20, and 22. * Include steps for restoring cache, installing dependencies, running tests, and submitting coverage data. * Define a workflow named `validate-publish` with multiple jobs and dependencies. * Add a setup node step in each job where npm is used. * Delete `.circleci/config.yml`. * Add `.nvmrc` file to set the Node.js version to 20.19. * Update `package.json` to specify Node.js version 20.19 in the engines field. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/gathertown/worklet-loader?shareId=XXXX-XXXX-XXXX-XXXX).
* Modify `.github/workflows/ci.yml` to set the workflow to run on `push: {}`
* Update `.nvmrc` to set the Node.js version to `20.19.0`
…ns/cache and actions/setup-node * Change all instances of `actions/cache@v2` to `actions/cache@v4` in `.github/workflows/ci.yml` * Change all instances of `actions/setup-node@v2` to `actions/setup-node@v4` in `.github/workflows/ci.yml`
* Update `.github/workflows/ci.yml` to use `yarn` instead of `npm` for installing dependencies and running scripts - Change cache key to use `yarn.lock` instead of `package-lock.json` - Remove `yarn run security` step * Update `package.json` to use `yarn` instead of `npm` in the `scripts` section - Remove `security` script and `nsp` dependency
nsheaps
force-pushed
the
nsheaps/nate/convert-circleci-to-github-actions
branch
from
f6ecadf to
6f32976
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the CI pipeline from CircleCI to GitHub Actions and standardizes project tooling around Node.js 20.19.0 and Yarn.
- Introduce
.github/workflows/ci.ymlfor testing and linting across Node.js 18, 20, 22. - Remove the CircleCI configuration and
.jestrc, add.nvmrcto pin Node.js to 20.19.0. - Update
package.jsonscripts to use Yarn, set theenginesfield to Node 20.19.0, and revise author metadata.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/worklets/InlineWorklet.js | Remove outdated comments around the BlobBuilder API. |
| package.json | Switch npm to Yarn scripts, update Node engine, author. |
| LICENSE | Update copyright metadata (contains a typo). |
| .nvmrc | Add file to pin Node.js version to 20.19.0. |
| .jestrc | Remove Jest config (testEnvironment may need relocating). |
| .github/workflows/ci.yml | Add GitHub Actions workflow for CI. |
| .circleci/config.yml | Delete CircleCI configuration. |
Comments suppressed due to low confidence (1)
.jestrc:2
- Removing this Jest config may cause tests to run with the default environment (jsdom). If Node environment is required, add
testEnvironment: "node"back into your Jest configuration (e.g., in package.json).
"testEnvironment": "node"
| @@ -1,4 +1,5 @@ | |||
| Additions and modifications to `worker-loader` copyright (c) 2018 Walker Henderson | |||
| Additions and modifications to `worlet-loader` copyright (c) 2025 Gather Presence, Inc. | |||
There was a problem hiding this comment.
It looks like worlet-loader is a typo—should be worker-loader to match the original project name.
Suggested change
| Additions and modifications to `worlet-loader` copyright (c) 2025 Gather Presence, Inc. | |
| Additions and modifications to `worker-loader` copyright (c) 2025 Gather Presence, Inc. |
…gin support; fix start script in package.json
…ps://github.com/gathertown/worklet-loader into nsheaps/nate/convert-circleci-to-github-actions
jaredallard
reviewed
May 15, 2025
| @@ -0,0 +1 @@ | |||
| 20.19.2 | |||
jaredallard
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate from CircleCI to GitHub Actions
.github/workflows/ci.yml.nvmrcfile specifying Node.js 20.19.2.jestrctojest.config.jsGitHub Actions workflows include test jobs with proper caching, dependency installation, and test execution across multiple Node.js versions, plus a separate analysis job for linting.