refac: use emotion for registering fonts#212
Merged
Conversation
Grafana plugin validator has 'no-direct-css-imports' rule: https://github.com/grafana/plugin-validator/blob/7be5debe7d9e2061c382b443ab1b149c59b87d8b/pkg/analysis/passes/coderules/semgrep-rules.yaml#L198 To follow that rule, use emotion to register the fonts instead of direct CSS imports.
Bundle Size ChangesHello! 👋 This comment was generated by a Github Action to help you and reviewers understand the impact of your PR on frontend bundle sizes. Whenever this PR is updated, this comment will update to reflect the latest changes.
View detailed bundle informationAdded
Removed
Bigger No assets were bigger Smaller
View module informationAdded
Removed
Bigger No modules were bigger Smaller
|
Instead of registering the font on every render, it now only registers the fonts when the module is loaded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grafana plugin validator has 'no-direct-css-imports' rule: https://github.com/grafana/plugin-validator/blob/7be5debe7d9e2061c382b443ab1b149c59b87d8b/pkg/analysis/passes/coderules/semgrep-rules.yaml#L198 To follow that rule, use emotion to register the fonts instead of direct CSS imports.