Open
Conversation
| @@ -0,0 +1,3 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
This is nice to have, but I dont think it is needed by everyone. Consider removing please.
Owner
There was a problem hiding this comment.
Indeed, can you remove this line?
gallexis
requested changes
Jul 22, 2022
Owner
gallexis
left a comment
gallexis
left a comment
There was a problem hiding this comment.
Looks good! It should improve the code thank you
| @@ -0,0 +1,3 @@ | |||
| #!/usr/bin/env bash | |||
Owner
There was a problem hiding this comment.
Indeed, can you remove this line?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create functionality for run the module by run.sh with a torrent file as a parameter so that cannot modify the main.py in case of new torrents.
Add logging to extend debugging.
Add multi threading to tracker.py for better performance.