By yanniboi: Added error replay for HubSpot Academy validation errors.#2
By yanniboi: Added error replay for HubSpot Academy validation errors.#2
Conversation
| private static ServiceBusProcessor _processor; | ||
|
|
||
| private const string QueueName = "error"; | ||
|
|
There was a problem hiding this comment.
Now that we have several different error queues I though we might benefit from a global variable to switch which queue we are processing.
gallaca
left a comment
gallaca
left a comment
There was a problem hiding this comment.
I've left a few comments. I think your changes all represent an improvement but would suggest that a few small additional changes make it even better!
| @@ -1,4 +1,6 @@ | |||
| namespace MessageBusReader | |||
| using MessageBusReader.QueueProcessingHandlers; | |||
There was a problem hiding this comment.
Opinions vary on whether usings should be inside or outside of the namespace. However, please don't do both in the same class.
| private static ServiceBusProcessor _processor; | ||
|
|
||
| // Customise your operational params. | ||
| private const string QueueName = "error"; |
There was a problem hiding this comment.
Can we call this new variable errorQueueName please?
|
|
||
| // Customise your operational params. | ||
| private const string QueueName = "error"; | ||
| private const string Env = "DEV_CONNECTION_STRING"; |
There was a problem hiding this comment.
I would expect a variable called Env to have values "dev", "qa" and "prod". We are conflating the environment with the only value (at present) that changes by environment. I think we can do this better?
2 participants
No description provided.