Skip to content

Tag fetching and searchable tags, but overrides existing list of tags#247

Merged
James-Cocker merged 11 commits intomainfrom
JamesC-iss2466-consistent-searchable-tags
Feb 6, 2026
Merged

Tag fetching and searchable tags, but overrides existing list of tags#247
James-Cocker merged 11 commits intomainfrom
JamesC-iss2466-consistent-searchable-tags

Conversation

@James-Cocker
Copy link
Contributor

@James-Cocker James-Cocker commented Jan 19, 2026

Why?

Solves #2466 by extending functionality of editing tags to be a filterable, selectable list of tags where you can query existing tag objects.

Signed-off-by: James Cocker <james.s.earth@gmail.com>
…ple tag type

Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
@jadecarino
Copy link
Member

@James-Cocker Hi James, from my testing mostly looks good but there's still some funny behaviour with the sorting. Here's how to recreate:

  1. Go to a test run with no runs
  2. Add the tags 'artifact' and 'http' from the dropdown
  3. Add a tag 'jade' (after http alphabetically) and it appears in the correct alphabetical order (artifact, http, jade)
  4. Then unselect 'http' as a tag and the order will put 'http' at the bottom of the list

Is this the intended behaviour? I've been playing around and it seems to be some inconsistencies between sometimes the ticked tags group together and then the unticked tags group together, and each group is alphabetically sorted, and then sometimes alternatively the whole tags list both ticked and unticked are combined and sorted alphabetically as a whole. Whatever behaviour you decide upon should stay consistent I believe.

… change

Signed-off-by: James Cocker <james.s.earth@gmail.com>
@James-Cocker
Copy link
Contributor Author

Hey @jadecarino I found the issue that you were experiencing and showed me on our call. Should be all fixed now 😁.

Copy link
Member

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks James! Lets hold fire for now on merging until I have decided on when we are doing the patch release.

@James-Cocker James-Cocker merged commit fe9e90a into main Feb 6, 2026
7 of 8 checks passed
@James-Cocker James-Cocker deleted the JamesC-iss2466-consistent-searchable-tags branch February 6, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants