Tag fetching and searchable tags, but overrides existing list of tags#247
Tag fetching and searchable tags, but overrides existing list of tags#247James-Cocker merged 11 commits intomainfrom
Conversation
Signed-off-by: James Cocker <james.s.earth@gmail.com>
…ple tag type Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
|
@James-Cocker Hi James, from my testing mostly looks good but there's still some funny behaviour with the sorting. Here's how to recreate:
Is this the intended behaviour? I've been playing around and it seems to be some inconsistencies between sometimes the ticked tags group together and then the unticked tags group together, and each group is alphabetically sorted, and then sometimes alternatively the whole tags list both ticked and unticked are combined and sorted alphabetically as a whole. Whatever behaviour you decide upon should stay consistent I believe. |
… change Signed-off-by: James Cocker <james.s.earth@gmail.com>
|
Hey @jadecarino I found the issue that you were experiencing and showed me on our call. Should be all fixed now 😁. |
jadecarino
left a comment
There was a problem hiding this comment.
Looks good, thanks James! Lets hold fire for now on merging until I have decided on when we are doing the patch release.
Why?
Solves #2466 by extending functionality of editing tags to be a filterable, selectable list of tags where you can query existing tag objects.