add repo_find function #14 #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
it doesn't work for paths like /p1/p2/../p3 and /p1/p2/.., but i think that we don't need this feature for now. |
|
Good implementation of take_parent_dir! |
gabrycina
requested changes
Apr 18, 2024
| return repo | ||
| return repo | ||
|
|
||
| def take_parent_dir(path): |
Owner
There was a problem hiding this comment.
I prefer the recursive solution suggested by the guide. You also mentioned this is not working for all paths.
Readability >>>
| if path[i] == "/": | ||
| break | ||
|
|
||
| if i == 0: |
Owner
There was a problem hiding this comment.
Is "i" present after the for loops? It seems not. How is this working?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.