[PHEE-712] Added batch details negative test cases#23
[PHEE-712] Added batch details negative test cases#23dhruvsonagara wants to merge 2 commits intodevelopfrom
Conversation
|
|
||
| Scenario: BD-020 Batch details with invalid batchId | ||
| Given I have tenant as "paymentbb2" | ||
| When I call the Batches API with invalid batchId expecting status of 400 |
There was a problem hiding this comment.
please explain how the batchId is invalid
There was a problem hiding this comment.
add more details to the feature file so that the test case is well explained in the feature file itself
|
|
||
| Scenario: BD-021 Batch details with invalid pageNo and pageSize | ||
| Given I have tenant as "paymentbb2" | ||
| When I call the Batches API with invalid pageNo and pageSize expecting status of 400 |
There was a problem hiding this comment.
here as well. mention the values passed.
|
|
||
| Scenario: BD-022 Batch details with invalid status | ||
| Given I have tenant as "paymentbb2" | ||
| When I call the Batches API with invalid status expecting status of 400 |
| // String requestId = "1234"; | ||
|
|
||
| String endpoint = String.format("%s?batchId=%s", operationsAppConfig.batchDetailsEndpoint, batchId); | ||
| String fullUrl = operationsAppConfig.operationAppContactPoint + endpoint; |
There was a problem hiding this comment.
the string. format in the above line can be used to create the full URL. no need to add this additional line
There was a problem hiding this comment.
fullUrl is not used anywhere other than logs
| float pageSize = -2; | ||
|
|
||
| String endpoint = String.format("%s?pageNo=%f&pageSize=%f", operationsAppConfig.batchDetailsEndpoint, pageNo, pageSize); | ||
| String fullUrl = operationsAppConfig.operationAppContactPoint + endpoint; |
There was a problem hiding this comment.
the string. format in the above line can be used to create the full URL. no need to add this additional line
There was a problem hiding this comment.
fullUrl is not used anywhere other than logs
| String status = "DONE"; | ||
|
|
||
| String endpoint = String.format("%s?status=%s", operationsAppConfig.batchDetailsEndpoint, status); | ||
| String fullUrl = operationsAppConfig.operationAppContactPoint + endpoint; |
There was a problem hiding this comment.
the string. format in the above line can be used to create the full URL. no need to add this additional line
There was a problem hiding this comment.
fullUrl is not used anywhere other than logs
2 participants
Description
[].Format:
[jira_ticket] descriptionex: [phee-123] PR title.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Followed the PR title naming convention mentioned above.
Acknowledge that we will not merge PRs that are not passing the checks ("green") - it is your (author's) responsibility to get a proposed PR to pass all the checks, not primarily the project's maintainers.
The PR title should include a JIRA ticket
Design-related bullet points or design document links related to this PR added in the description above.
Updated corresponding Postman Collection or API documentation for the changes in this PR.
Create/update unit or integration tests for verifying the changes made.
Add required Swagger annotation and update API documentation with details of any API changes if applicable
Followed the naming conventions as given in https://docs.google.com/document/d/1Q4vaMSzrTxxh9TS0RILuNkSkYCxotuYk1Xe0CMIkkCU/edit?usp=sharing
Followed coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
FYI our guidelines for code reviews same as https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.