Skip to content

Comments

docs: clean up README#1715

Open
JustARatherRidiculouslyLongUsername wants to merge 2 commits intomasterfrom
cleanup-readme
Open

docs: clean up README#1715
JustARatherRidiculouslyLongUsername wants to merge 2 commits intomasterfrom
cleanup-readme

Conversation

@JustARatherRidiculouslyLongUsername
Copy link
Contributor

@JustARatherRidiculouslyLongUsername JustARatherRidiculouslyLongUsername commented Jan 13, 2026

Description

Fix structure, remove outdated sections, and update npm install to npm ci

Clickup

app.clickup.com

Summary by CodeRabbit

  • Documentation
    • Restructured and expanded README with comprehensive local development setup guide
    • Added detailed step-by-step instructions for cloning the repository, configuring the Node environment, installing dependencies, and running the application
    • Introduced explicit commands for backend services and worker processes
    • Added sections for environment configuration and per-theme startup instructions

✏️ Tip: You can customize this high-level summary in your review settings.

Fix structure, remove outdated sections, and update `npm install` to `npm ci`
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 13, 2026

Walkthrough

The README was restructured from a minimal prerequisites section into a comprehensive local development setup guide. Added step-by-step instructions for cloning the repository, starting backend services, configuring Node.js via NVM, installing dependencies, setting environment files, and running the application with optional theme support.

Changes

Cohort / File(s) Summary
Documentation restructuring
README.md
Expanded from minimal prerequisites to end-to-end setup guide; added detailed sections for repo cloning, backend service startup, Node/NVM configuration, dependency installation (npm ci), environment setup, app execution with theme support, and testing/storybook references; removed login snippet.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A README once bare, now blooming so bright,
With steps laid out clear from morning to night,
Setup to storybook, all in a row,
The warren of wisdom now easier to know! 📚✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: restructuring and cleaning up the README documentation with improved organization and updated commands.
Description check ✅ Passed The description covers the main objectives (fix structure, remove outdated sections, update npm install to npm ci) but lacks detail and the Clickup link appears incomplete (should be a full URL).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Fix all issues with AI agents
In @README.md:
- Line 7: The README uses multiple h4 (####) headings that skip h3, so update
the heading hierarchy to increment by one level: change the top-level section
headings currently using "####" (lines referenced like the section starting
"Setup all integrations-related repos" and likewise at lines 12, 29, 53, 84,
105) to "###" and ensure any subsections beneath them use "####" as appropriate
so headings progress sequentially (h3 → h4 → h5) throughout the file.
- Line 61: Fix the typo in the README heading: change the heading text "#### 5.
Copy environement files from Integrations Central" to "#### 5. Copy environment
files from Integrations Central" so "environement" is corrected to
"environment".
- Around line 45-46: Remove the extra spaces in the noted README lines: collapse
the multiple spaces in the line containing `nvm alias default v22.14.0` and the
subsequent sentence about upgrading from `v20.17.0 to v22.14.0` so they use
normal single spacing and consistent wrapping; ensure punctuation and
indentation remain unchanged and the two lines read cleanly with single spaces
between words.
🧹 Nitpick comments (1)
README.md (1)

92-92: Consider adjusting list indentation for consistency.

The unordered list items have 3-space indentation, which deviates from the expected 0-space indentation for top-level lists. While the current indentation may be intentional to show these as sub-options, consider either:

  1. Using standard 0-space indentation for consistency
  2. Converting to a proper nested list structure
♻️ Option 1: Standard indentation
-   * Run app in Fyle theme
+* Run app in Fyle theme

-   * Run app in Capital One theme
+* Run app in Capital One theme

Also applies to: 98-98

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between afd5046 and dce9ff5.

📒 Files selected for processing (1)
  • README.md
🧰 Additional context used
🪛 LanguageTool
README.md

[grammar] ~61-~61: Ensure spelling is correct
Context: ... bash npm ci #### 5. Copy environement files from Integrations Central * Copy...

(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)

🪛 markdownlint-cli2 (0.18.1)
README.md

7-7: Heading levels should only increment by one level at a time
Expected: h3; Actual: h4

(MD001, heading-increment)


92-92: Unordered list indentation
Expected: 0; Actual: 3

(MD007, ul-indent)


98-98: Unordered list indentation
Expected: 0; Actual: 3

(MD007, ul-indent)

🔇 Additional comments (3)
README.md (3)

5-110: Excellent restructuring of the README!

The transformation from minimal prerequisites to a comprehensive step-by-step setup guide significantly improves the developer onboarding experience. The change from npm install to npm ci and the addition of theme-specific run commands are valuable improvements.


38-40: Node.js version v22.14.0 is valid and current.

This is an LTS release with security support through April 30, 2027, making it an appropriate choice for the project.


55-55: Description is accurate. The npm ci documentation confirms it does remove existing node_modules before installing (installs strictly from package-lock.json). No changes needed.

Comment on lines +45 to +46
> * `nvm alias default v22.14.0` will set the node version to v22.14.0. Whenever a new shell session is opened, the default Node.js version will be v22.14.0.
> * If you're upgrading your node version, all your global packages needs to be re-installed. For example, if you're upgrading from v20.17.0 to v22.14.0, you can do following:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix extra whitespace in note.

Lines 45 and 46 contain extra spaces that disrupt readability.

📝 Proposed fix
-   > * `nvm alias default v22.14.0` will set the node version to v22.14.0. Whenever a new    shell session is opened, the default Node.js version will be v22.14.0.
-   > * If you're upgrading your node version, all your global packages needs to be    re-installed. For example, if you're upgrading from v20.17.0 to v22.14.0, you can do    following:
+   > * `nvm alias default v22.14.0` will set the node version to v22.14.0. Whenever a new shell session is opened, the default Node.js version will be v22.14.0.
+   > * If you're upgrading your node version, all your global packages needs to be re-installed. For example, if you're upgrading from v20.17.0 to v22.14.0, you can do following:
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
> * `nvm alias default v22.14.0` will set the node version to v22.14.0. Whenever a new shell session is opened, the default Node.js version will be v22.14.0.
> * If you're upgrading your node version, all your global packages needs to be re-installed. For example, if you're upgrading from v20.17.0 to v22.14.0, you can do following:
> * `nvm alias default v22.14.0` will set the node version to v22.14.0. Whenever a new shell session is opened, the default Node.js version will be v22.14.0.
> * If you're upgrading your node version, all your global packages needs to be re-installed. For example, if you're upgrading from v20.17.0 to v22.14.0, you can do following:
🤖 Prompt for AI Agents
In @README.md around lines 45 - 46, Remove the extra spaces in the noted README
lines: collapse the multiple spaces in the line containing `nvm alias default
v22.14.0` and the subsequent sentence about upgrading from `v20.17.0 to
v22.14.0` so they use normal single spacing and consistent wrapping; ensure
punctuation and indentation remain unchanged and the two lines read cleanly with
single spaces between words.

npm ci
```

#### 5. Copy environement files from Integrations Central
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Fix spelling: "environement" → "environment".

📝 Proposed fix
-#### 5. Copy environement files from Integrations Central
+#### 5. Copy environment files from Integrations Central
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
#### 5. Copy environement files from Integrations Central
#### 5. Copy environment files from Integrations Central
🧰 Tools
🪛 LanguageTool

[grammar] ~61-~61: Ensure spelling is correct
Context: ... bash npm ci #### 5. Copy environement files from Integrations Central * Copy...

(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)

🤖 Prompt for AI Agents
In @README.md at line 61, Fix the typo in the README heading: change the heading
text "#### 5. Copy environement files from Integrations Central" to "#### 5.
Copy environment files from Integrations Central" so "environement" is corrected
to "environment".

@github-actions
Copy link

🔁 Code Duplication Report - Angular

Format Files analyzed Total lines Total tokens Clones found Duplicated lines Duplicated tokens
typescript 780 57440 526649 330 5443 (9.48%) 51552 (9.79%)
scss 68 3791 20510 7 148 (3.90%) 769 (3.75%)
markup 340 17549 164998 155 2082 (11.86%) 17544 (10.63%)
python 4 727 5680 3 32 (4.40%) 368 (6.48%)
yaml 3 155 905 0 0 (0.00%) 0 (0.00%)
javascript 5 295 3063 0 0 (0.00%) 0 (0.00%)
markdown 2 134 823 0 0 (0.00%) 0 (0.00%)
bash 2 69 804 0 0 (0.00%) 0 (0.00%)
Total: 1204 80160 723432 495 7705 (9.61%) -0.01% 🚀 70233 (9.71%)

📊 No significant change in code duplication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Medium PR

Development

Successfully merging this pull request may close these issues.

3 participants