fix: dashboard spacing and intacct imp settings dim sentence case#1374
Open
vignesh05904 wants to merge 6 commits intomasterfrom
Open
fix: dashboard spacing and intacct imp settings dim sentence case#1374vignesh05904 wants to merge 6 commits intomasterfrom
vignesh05904 wants to merge 6 commits intomasterfrom
Conversation
Contributor
WalkthroughThe updates include a modification to capitalize the first letter of the Changes
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
npm error Exit handler never called! 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🧰 Additional context used🧠 Learnings (3)📓 Common learningssrc/app/integrations/intacct/intacct-shared/intacct-import-settings/intacct-import-settings.component.ts (6)src/app/shared/components/dashboard/dashboard-export-summary-section/dashboard-export-summary-section.component.html (4)⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ashwin1111
reviewed
Jul 8, 2025
| <!-- Temporary hack to enable repurposed export summary only for allowed apps - #q2_real_time_exports_integrations --> | ||
| @if (brandingFeatureConfig.featureFlags.dashboard.useRepurposedExportSummary && [AppName.XERO, AppName.QBO, AppName.NETSUITE, AppName.INTACCT, AppName.QBD_DIRECT, AppName.SAGE300].includes(appName)) { | ||
| <span class="tw-w-150-px tw-text-right tw-text-14-px tw-font-500 tw-text-text-secondary"> | ||
| <span class="tw-w-150-px tw-py-10-px tw-text-right tw-text-14-px tw-font-500 tw-text-text-secondary"> |
Contributor
There was a problem hiding this comment.
can you pls drop a screenshot of how this section looks for fyle and c1 theme pls?
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
vignesh05904
added
the
staging_deploy
🚨 BugBot couldn't runSomething went wrong. Try again by commenting "bugbot run", or contact support (requestId: serverGenReqId_ac5bcb85-3556-432c-a2ec-f39eff73e10b). |
|
There was a problem hiding this comment.
Bug: Null/Undefined Handling in String Methods
Calling charAt(0) and slice(1) on field.display_name without null/undefined checks will throw a TypeError at runtime if field.display_name is null or undefined. The previous implementation would have gracefully passed these values through.
src/app/integrations/intacct/intacct-shared/intacct-import-settings/intacct-import-settings.component.ts#L616-L617
Was this report helpful? Give feedback by reacting with 👍 or 👎
🔁 Code Duplication Report - Angular
📊 No significant change in code duplication. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
dashboard spacing and intacct imp settings dim sentence case
Clickup
https://app.clickup.com/1864988/v/l/li/901607316229
Summary by CodeRabbit
Style
Refactor